From: Krzysztof Kozlowski <krzk@kernel.org>
To: Doug Anderson <dianders@chromium.org>,
Cong Yang <yangcong5@huaqin.corp-partner.google.com>
Cc: benjamin.tissoires@redhat.com, devicetree@vger.kernel.org,
dmitry.torokhov@gmail.com, hsinyi@google.com, jikos@kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
mka@chromium.org
Subject: Re: [v2 2/2] dt-bindings: input: touchscreen: Add ilitek 9882T touchscreen chip
Date: Tue, 30 May 2023 13:56:11 +0200 [thread overview]
Message-ID: <bd19f71b-59ee-80e7-9ff1-1cc26ecc49a7@kernel.org> (raw)
In-Reply-To: <CAD=FV=Wm_SK0V6WJUkuvu8yFfiP60JBuOdw9cy=0Ck2Jbn-X2A@mail.gmail.com>
On 22/05/2023 17:33, Doug Anderson wrote:
> Hi,
>
> On Fri, May 19, 2023 at 10:07 PM Cong Yang
> <yangcong5@huaqin.corp-partner.google.com> wrote:
>>
>> Add an ilitek touch screen chip ili9882t.
>>
>> Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com>
>> ---
>> .../devicetree/bindings/input/elan,ekth6915.yaml | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> I'm curious about the DT maintainers opinion here. Should this be a
> new bindings file, or should it be together in the elan file. If
> nothing else, I think the secondary voltage rail name is wrong. I took
> a quick peek at a datasheet I found and I don't even see a 3.3V rail
> going to the ili9882t. That makes it weird to reuse "vcc33-supply" for
> a second supply...
It's easier if they are CCed...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-30 11:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 9:01 [PATCH] HID: i2c-hid: goodix: Add ili9882t timing Cong Yang
2023-05-19 14:01 ` Doug Anderson
2023-05-20 5:06 ` [v2 0/2] " Cong Yang
2023-05-20 5:06 ` [v2 1/2] HID: i2c-hid: elan: " Cong Yang
2023-05-22 15:27 ` Doug Anderson
2023-05-30 21:24 ` Dmitry Torokhov
2023-05-20 5:06 ` [v2 2/2] dt-bindings: input: touchscreen: Add ilitek 9882T touchscreen chip Cong Yang
2023-05-22 15:33 ` Doug Anderson
2023-05-30 11:56 ` Krzysztof Kozlowski [this message]
2023-05-30 16:58 ` Doug Anderson
[not found] ` <CAHwB_N+ZpCAYftCLRwyNo2wCca+JHfGJc0_rJ=jwJcU0mbG=Dw@mail.gmail.com>
2023-06-01 15:40 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd19f71b-59ee-80e7-9ff1-1cc26ecc49a7@kernel.org \
--to=krzk@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hsinyi@google.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox