mainline build failure due to 8295efbe68c0 ("md/raid1-10: factor out a helper to submit normal write")

mainline build failure due to 8295efbe68c0 ("md/raid1-10: factor out a helper to submit normal write")

[Sudip Mukherjee (Codethink)]

Hi All,

The latest mainline kernel branch fails to build x86_64, arm64 and arm allmodconfig
with clang (version 16.0.1), and the error is:

In file included from drivers/md/raid1.c:52:
drivers/md/raid1-10.c:119:25: error: casting from randomized structure pointer type 'struct block_device *' to 'struct md_rdev *'
        struct md_rdev *rdev = (struct md_rdev *)bio->bi_bdev;
                               ^

git bisect pointed to 8295efbe68c0 ("md/raid1-10: factor out a helper to submit normal write").

Reverting the commit has fixed the build failure.

I will be happy to test any patch or provide any extra log if needed.

#regzbot introduced: 8295efbe68c080047e98d9c0eb5cb933b238a8cb

-- 
Regards
Sudip

Re: mainline build failure due to 8295efbe68c0 ("md/raid1-10: factor out a helper to submit normal write")

[Yu Kuai]

Hi,

在 2023/06/29 21:32, Sudip Mukherjee (Codethink) 写道:
> Hi All,
> 
> The latest mainline kernel branch fails to build x86_64, arm64 and arm allmodconfig

Thanks for the testing, which branch are you testing?

This problem is already fixed in latest mainline kernel:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b5a99602b74bbfa655be509c615181dd95b0719e

Kuai
> with clang (version 16.0.1), and the error is:
> 
> In file included from drivers/md/raid1.c:52:
> drivers/md/raid1-10.c:119:25: error: casting from randomized structure pointer type 'struct block_device *' to 'struct md_rdev *'
>          struct md_rdev *rdev = (struct md_rdev *)bio->bi_bdev;
>                                 ^
> 
> git bisect pointed to 8295efbe68c0 ("md/raid1-10: factor out a helper to submit normal write").
> 
> Reverting the commit has fixed the build failure.
> 
> I will be happy to test any patch or provide any extra log if needed.
> 
> #regzbot introduced: 8295efbe68c080047e98d9c0eb5cb933b238a8cb
> 

Re: mainline build failure due to 8295efbe68c0 ("md/raid1-10: factor out a helper to submit normal write")

[Sudip Mukherjee]

Hi Kuai,

On Thu, 29 Jun 2023 at 14:56, Yu Kuai <yukuai1@huaweicloud.com> wrote:
>
> Hi,
>
> 在 2023/06/29 21:32, Sudip Mukherjee (Codethink) 写道:
> > Hi All,
> >
> > The latest mainline kernel branch fails to build x86_64, arm64 and arm allmodconfig
>
> Thanks for the testing, which branch are you testing?
>
> This problem is already fixed in latest mainline kernel:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b5a99602b74bbfa655be509c615181dd95b0719e

The link you gave is not "mainline kernel". Its linux-next.

Linus still does not have the fix, so the mainline kernel branch fails.


-- 
Regards
Sudip

Re: mainline build failure due to 8295efbe68c0 ("md/raid1-10: factor out a helper to submit normal write")

[Linux regression tracking (Thorsten Leemhuis)]

On 29.06.23 15:56, Yu Kuai wrote:
> 
> 在 2023/06/29 21:32, Sudip Mukherjee (Codethink) 写道:
>> The latest mainline kernel branch fails to build x86_64, arm64 and arm
>> allmodconfig

Thx for the report.

> Thanks for the testing, which branch are you testing?
> 
> This problem is already fixed in latest mainline kernel:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b5a99602b74bbfa655be509c615181dd95b0719e

And thx for the reply. :-D

FWIW, that fix afaics is still in -next and hasn't reached mainline yet.
But I guess that will change within a few days.

>> #regzbot introduced: 8295efbe68c080047e98d9c0eb5cb933b238a8cb

#regzbot fix: b5a99602b74bbfa6
#regzbot dup-of: https://lore.kernel.org/all/ZJ2M4yqnOCqqGWH0@debian/
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

Re: mainline build failure due to 8295efbe68c0 ("md/raid1-10: factor out a helper to submit normal write")

[Song Liu]

+ Jens,

On Thu, Jun 29, 2023 at 7:10 AM Linux regression tracking (Thorsten
Leemhuis) <regressions@leemhuis.info> wrote:
>
> On 29.06.23 15:56, Yu Kuai wrote:
> >
> > 在 2023/06/29 21:32, Sudip Mukherjee (Codethink) 写道:
> >> The latest mainline kernel branch fails to build x86_64, arm64 and arm
> >> allmodconfig
>
> Thx for the report.
>
> > Thanks for the testing, which branch are you testing?
> >
> > This problem is already fixed in latest mainline kernel:
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b5a99602b74bbfa655be509c615181dd95b0719e

Hi Jens,

The fix is in the for-6.5/block-late branch.

https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-6.5/block-late&id=b5a99602b74bbfa655be509c615181dd95b0719e

Would you send a pull request with it? Or would you prefer
some other solution for the issue?

AFAICT, it will fix clang build with RANDSTRUCT.

Thanks,
Song

>
> And thx for the reply. :-D
>
> FWIW, that fix afaics is still in -next and hasn't reached mainline yet.
> But I guess that will change within a few days.
>
> >> #regzbot introduced: 8295efbe68c080047e98d9c0eb5cb933b238a8cb
>
> #regzbot fix: b5a99602b74bbfa6
> #regzbot dup-of: https://lore.kernel.org/all/ZJ2M4yqnOCqqGWH0@debian/
> #regzbot ignore-activity
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.

Re: mainline build failure due to 8295efbe68c0 ("md/raid1-10: factor out a helper to submit normal write")

[Song Liu]

Oops, didn't really add Jens in the previous email.

Add Jens now.

On Thu, Jun 29, 2023 at 8:55 AM Song Liu <song@kernel.org> wrote:
>
> + Jens,
>
> On Thu, Jun 29, 2023 at 7:10 AM Linux regression tracking (Thorsten
> Leemhuis) <regressions@leemhuis.info> wrote:
> >
> > On 29.06.23 15:56, Yu Kuai wrote:
> > >
> > > 在 2023/06/29 21:32, Sudip Mukherjee (Codethink) 写道:
> > >> The latest mainline kernel branch fails to build x86_64, arm64 and arm
> > >> allmodconfig
> >
> > Thx for the report.
> >
> > > Thanks for the testing, which branch are you testing?
> > >
> > > This problem is already fixed in latest mainline kernel:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b5a99602b74bbfa655be509c615181dd95b0719e
>
> Hi Jens,
>
> The fix is in the for-6.5/block-late branch.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-6.5/block-late&id=b5a99602b74bbfa655be509c615181dd95b0719e
>
> Would you send a pull request with it? Or would you prefer
> some other solution for the issue?
>
> AFAICT, it will fix clang build with RANDSTRUCT.
>
> Thanks,
> Song
>
> >
> > And thx for the reply. :-D
> >
> > FWIW, that fix afaics is still in -next and hasn't reached mainline yet.
> > But I guess that will change within a few days.
> >
> > >> #regzbot introduced: 8295efbe68c080047e98d9c0eb5cb933b238a8cb
> >
> > #regzbot fix: b5a99602b74bbfa6
> > #regzbot dup-of: https://lore.kernel.org/all/ZJ2M4yqnOCqqGWH0@debian/
> > #regzbot ignore-activity
> >
> > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> > --
> > Everything you wanna know about Linux kernel regression tracking:
> > https://linux-regtracking.leemhuis.info/about/#tldr
> > If I did something stupid, please tell me, as explained on that page.

Re: mainline build failure due to 8295efbe68c0 ("md/raid1-10: factor out a helper to submit normal write")

[Jens Axboe]

The late branch will go out some time next week.


On 6/29/23 9:56?AM, Song Liu wrote:
> Oops, didn't really add Jens in the previous email.
> 
> Add Jens now.
> 
> On Thu, Jun 29, 2023 at 8:55?AM Song Liu <song@kernel.org> wrote:
>>
>> + Jens,
>>
>> On Thu, Jun 29, 2023 at 7:10?AM Linux regression tracking (Thorsten
>> Leemhuis) <regressions@leemhuis.info> wrote:
>>>
>>> On 29.06.23 15:56, Yu Kuai wrote:
>>>>
>>>> ? 2023/06/29 21:32, Sudip Mukherjee (Codethink) ??:
>>>>> The latest mainline kernel branch fails to build x86_64, arm64 and arm
>>>>> allmodconfig
>>>
>>> Thx for the report.
>>>
>>>> Thanks for the testing, which branch are you testing?
>>>>
>>>> This problem is already fixed in latest mainline kernel:
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b5a99602b74bbfa655be509c615181dd95b0719e
>>
>> Hi Jens,
>>
>> The fix is in the for-6.5/block-late branch.
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-6.5/block-late&id=b5a99602b74bbfa655be509c615181dd95b0719e
>>
>> Would you send a pull request with it? Or would you prefer
>> some other solution for the issue?
>>
>> AFAICT, it will fix clang build with RANDSTRUCT.
>>
>> Thanks,
>> Song
>>
>>>
>>> And thx for the reply. :-D
>>>
>>> FWIW, that fix afaics is still in -next and hasn't reached mainline yet.
>>> But I guess that will change within a few days.
>>>
>>>>> #regzbot introduced: 8295efbe68c080047e98d9c0eb5cb933b238a8cb
>>>
>>> #regzbot fix: b5a99602b74bbfa6
>>> #regzbot dup-of: https://lore.kernel.org/all/ZJ2M4yqnOCqqGWH0@debian/
>>> #regzbot ignore-activity
>>>
>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>> --
>>> Everything you wanna know about Linux kernel regression tracking:
>>> https://linux-regtracking.leemhuis.info/about/#tldr
>>> If I did something stupid, please tell me, as explained on that page.

-- 
Jens Axboe