* [PATCH v2 bpf-next] selftests/bpf: Corrected two typos
@ 2023-07-07 8:12 Lu Hongfei
2023-07-07 9:17 ` Hou Tao
2023-07-07 17:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Lu Hongfei @ 2023-07-07 8:12 UTC (permalink / raw)
To: Andrii Nakryiko, Mykola Lysenko, Alexei Starovoitov,
Daniel Borkmann, Martin KaFai Lau, Song Liu, Yonghong Song,
John Fastabend, KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa,
Shuah Khan, Hou Tao, Lu Hongfei, Anton Protopopov, Wang Yufen,
YiFei Zhu, bpf, linux-kselftest, linux-kernel
Cc: opensource.kernel
When wrapping code, use ';' better than using ',' which is more
in line with the coding habits of most engineers.
Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
Compared to the previous version, the modifications made are:
1. Modified the subject to make it clearer and more accurate
2. Newly optimized typo in tcp_hdr_options.c
tools/testing/selftests/bpf/benchs/bench_ringbufs.c | 2 +-
tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/benchs/bench_ringbufs.c b/tools/testing/selftests/bpf/benchs/bench_ringbufs.c
index 3ca14ad36607..e1ee979e6acc 100644
--- a/tools/testing/selftests/bpf/benchs/bench_ringbufs.c
+++ b/tools/testing/selftests/bpf/benchs/bench_ringbufs.c
@@ -399,7 +399,7 @@ static void perfbuf_libbpf_setup(void)
ctx->skel = perfbuf_setup_skeleton();
memset(&attr, 0, sizeof(attr));
- attr.config = PERF_COUNT_SW_BPF_OUTPUT,
+ attr.config = PERF_COUNT_SW_BPF_OUTPUT;
attr.type = PERF_TYPE_SOFTWARE;
attr.sample_type = PERF_SAMPLE_RAW;
/* notify only every Nth sample */
diff --git a/tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c b/tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c
index 13bcaeb028b8..56685fc03c7e 100644
--- a/tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c
+++ b/tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c
@@ -347,7 +347,7 @@ static void syncookie_estab(void)
exp_active_estab_in.max_delack_ms = 22;
exp_passive_hdr_stg.syncookie = true;
- exp_active_hdr_stg.resend_syn = true,
+ exp_active_hdr_stg.resend_syn = true;
prepare_out();
--
2.39.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 bpf-next] selftests/bpf: Corrected two typos
2023-07-07 8:12 [PATCH v2 bpf-next] selftests/bpf: Corrected two typos Lu Hongfei
@ 2023-07-07 9:17 ` Hou Tao
2023-07-07 16:54 ` Stanislav Fomichev
2023-07-07 17:40 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Hou Tao @ 2023-07-07 9:17 UTC (permalink / raw)
To: Lu Hongfei
Cc: opensource.kernel, Andrii Nakryiko, Mykola Lysenko,
Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev,
Hao Luo, Jiri Olsa, Shuah Khan, Anton Protopopov, Wang Yufen,
YiFei Zhu, bpf, linux-kselftest, linux-kernel
On 7/7/2023 4:12 PM, Lu Hongfei wrote:
> When wrapping code, use ';' better than using ',' which is more
> in line with the coding habits of most engineers.
>
> Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
> ---
> Compared to the previous version, the modifications made are:
> 1. Modified the subject to make it clearer and more accurate
> 2. Newly optimized typo in tcp_hdr_options.c
>
> tools/testing/selftests/bpf/benchs/bench_ringbufs.c | 2 +-
> tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Acked-by: Hou Tao <houtao1@huawei.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 bpf-next] selftests/bpf: Corrected two typos
2023-07-07 9:17 ` Hou Tao
@ 2023-07-07 16:54 ` Stanislav Fomichev
0 siblings, 0 replies; 4+ messages in thread
From: Stanislav Fomichev @ 2023-07-07 16:54 UTC (permalink / raw)
To: Hou Tao
Cc: Lu Hongfei, opensource.kernel, Andrii Nakryiko, Mykola Lysenko,
Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, John Fastabend, KP Singh, Hao Luo, Jiri Olsa,
Shuah Khan, Anton Protopopov, Wang Yufen, YiFei Zhu, bpf,
linux-kselftest, linux-kernel
On 07/07, Hou Tao wrote:
>
>
> On 7/7/2023 4:12 PM, Lu Hongfei wrote:
> > When wrapping code, use ';' better than using ',' which is more
> > in line with the coding habits of most engineers.
> >
> > Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
> > ---
> > Compared to the previous version, the modifications made are:
> > 1. Modified the subject to make it clearer and more accurate
> > 2. Newly optimized typo in tcp_hdr_options.c
> >
> > tools/testing/selftests/bpf/benchs/bench_ringbufs.c | 2 +-
> > tools/testing/selftests/bpf/prog_tests/tcp_hdr_options.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Acked-by: Hou Tao <houtao1@huawei.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 bpf-next] selftests/bpf: Corrected two typos
2023-07-07 8:12 [PATCH v2 bpf-next] selftests/bpf: Corrected two typos Lu Hongfei
2023-07-07 9:17 ` Hou Tao
@ 2023-07-07 17:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-07 17:40 UTC (permalink / raw)
To: Lu Hongfei
Cc: andrii, mykolal, ast, daniel, martin.lau, song, yhs,
john.fastabend, kpsingh, sdf, haoluo, jolsa, shuah, houtao1,
aspsk, wangyufen, zhuyifei, bpf, linux-kselftest, linux-kernel,
opensource.kernel
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Fri, 7 Jul 2023 16:12:50 +0800 you wrote:
> When wrapping code, use ';' better than using ',' which is more
> in line with the coding habits of most engineers.
>
> Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
> ---
> Compared to the previous version, the modifications made are:
> 1. Modified the subject to make it clearer and more accurate
> 2. Newly optimized typo in tcp_hdr_options.c
>
> [...]
Here is the summary with links:
- [v2,bpf-next] selftests/bpf: Corrected two typos
https://git.kernel.org/bpf/bpf-next/c/856fe03d9292
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-07 17:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-07 8:12 [PATCH v2 bpf-next] selftests/bpf: Corrected two typos Lu Hongfei
2023-07-07 9:17 ` Hou Tao
2023-07-07 16:54 ` Stanislav Fomichev
2023-07-07 17:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox