* [PATCH] locktorture: Check the correct variable for allocation failure
@ 2023-09-28 7:06 Dan Carpenter
2023-09-28 13:00 ` Frederic Weisbecker
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2023-09-28 7:06 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Davidlohr Bueso, Josh Triplett, Frederic Weisbecker, linux-kernel,
kernel-janitors
There is a typo so this checks the wrong variable. "chains" plural vs
"chain" singular. We already know that "chains" is non-zero.
Fixes: 7f993623e9eb ("locktorture: Add call_rcu_chains module parameter")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
kernel/locking/locktorture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
index a3abcd136f56..69d3cd2cfc3b 100644
--- a/kernel/locking/locktorture.c
+++ b/kernel/locking/locktorture.c
@@ -1075,7 +1075,7 @@ static int call_rcu_chain_init(void)
if (call_rcu_chains <= 0)
return 0;
call_rcu_chain = kcalloc(call_rcu_chains, sizeof(*call_rcu_chain), GFP_KERNEL);
- if (!call_rcu_chains)
+ if (!call_rcu_chain)
return -ENOMEM;
for (i = 0; i < call_rcu_chains; i++) {
call_rcu_chain[i].crc_stop = false;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] locktorture: Check the correct variable for allocation failure
2023-09-28 7:06 [PATCH] locktorture: Check the correct variable for allocation failure Dan Carpenter
@ 2023-09-28 13:00 ` Frederic Weisbecker
0 siblings, 0 replies; 2+ messages in thread
From: Frederic Weisbecker @ 2023-09-28 13:00 UTC (permalink / raw)
To: Dan Carpenter
Cc: Paul E. McKenney, Davidlohr Bueso, Josh Triplett, linux-kernel,
kernel-janitors
On Thu, Sep 28, 2023 at 10:06:11AM +0300, Dan Carpenter wrote:
> There is a typo so this checks the wrong variable. "chains" plural vs
> "chain" singular. We already know that "chains" is non-zero.
>
> Fixes: 7f993623e9eb ("locktorture: Add call_rcu_chains module parameter")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> kernel/locking/locktorture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
> index a3abcd136f56..69d3cd2cfc3b 100644
> --- a/kernel/locking/locktorture.c
> +++ b/kernel/locking/locktorture.c
> @@ -1075,7 +1075,7 @@ static int call_rcu_chain_init(void)
> if (call_rcu_chains <= 0)
> return 0;
> call_rcu_chain = kcalloc(call_rcu_chains, sizeof(*call_rcu_chain), GFP_KERNEL);
> - if (!call_rcu_chains)
> + if (!call_rcu_chain)
> return -ENOMEM;
> for (i = 0; i < call_rcu_chains; i++) {
> call_rcu_chain[i].crc_stop = false;
Oh good catch, queueing this one, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-28 13:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-28 7:06 [PATCH] locktorture: Check the correct variable for allocation failure Dan Carpenter
2023-09-28 13:00 ` Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox