From: Andi Shyti <andi.shyti@linux.intel.com>
To: Calvince Otieno <calvncce@gmail.com>
Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Luke Koch <lu.ale.koch@gmail.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Simon Horman <horms@kernel.org>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v2] staging: wlan-ng: remove helper function prism2sta_inf_handover()
Date: Fri, 13 Oct 2023 13:21:26 +0200 [thread overview]
Message-ID: <ZSkoNhWDxntTbGpm@ashyti-mobl2.lan> (raw)
In-Reply-To: <ZSkg7y2Y2T3midXB@lab-ubuntu>
Hi Calvince,
...
> @@ -1697,7 +1697,8 @@ void prism2sta_ev_info(struct wlandevice *wlandev,
> /* Dispatch */
> switch (inf->infotype) {
> case HFA384x_IT_HANDOVERADDR:
> - pr_debug("received infoframe:HANDOVER (unhandled)\n");
> + netdev_dbg(wlandev->netdev,
> + "received infoframe:HANDOVER (unhandled)\n");
but then you generate this:
CHECK: Alignment should match open parenthesis
#240: FILE: drivers/staging/wlan-ng/prism2sta.c:1701:
+ netdev_dbg(wlandev->netdev,
+ "received infoframe:HANDOVER (unhandled)\n");
total: 0 errors, 0 warnings, 1 checks, 9 lines checked
:-)
Make it a habit... before sending a patch check it with
checkpatch, in order to be sure you are not introducing other
checkpatch errors.
Don't rush... take your time, check your changes carefully; use
checkpatch, compile test, run sparse, etc. Give others time to
see your patch and comment.
Andi
next prev parent reply other threads:[~2023-10-13 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 10:50 [PATCH v2] staging: wlan-ng: remove helper function prism2sta_inf_handover() Calvince Otieno
2023-10-13 11:21 ` Andi Shyti [this message]
2023-10-13 12:12 ` Dan Carpenter
2023-10-13 16:04 ` Calvince Otieno
2023-10-15 16:11 ` Greg Kroah-Hartman
2023-10-16 4:40 ` Dan Carpenter
2023-10-16 8:46 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSkoNhWDxntTbGpm@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=bagasdotme@gmail.com \
--cc=calvncce@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lu.ale.koch@gmail.com \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox