From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Michal Wilczynski <michal.wilczynski@intel.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
rafael.j.wysocki@intel.com, lenb@kernel.org
Subject: Re: [PATCH v1 3/6] ACPI: acpi_video: Remove unnecessary driver_data clear
Date: Thu, 26 Oct 2023 15:22:24 +0300 [thread overview]
Message-ID: <ZTpaAMfDcwaZYO7S@smile.fi.intel.com> (raw)
In-Reply-To: <20231025111806.2416524-4-michal.wilczynski@intel.com>
On Wed, Oct 25, 2023 at 02:18:03PM +0300, Michal Wilczynski wrote:
> Commit
> 0d16710146a1 ("ACPI: bus: Set driver_data to NULL every time .add() fails")
It's fine to wrap it here, it's just a restriction in the tag block that one
tag == one line. Also I believe the form "The commit" sounds more English :-)
as reader knows exact commit we are talking about.
> introduced clearing driver_data every time probe fails, so it's not
> necessary to clear it in the probe() callback.
> Remove NULL assignment to driver_data in error path in
> acpi_video_bus_add().
This can be one line.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-10-26 12:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 11:18 [PATCH v1 0/6] Replace acpi_driver with platform_driver Michal Wilczynski
2023-10-25 11:18 ` [PATCH v1 1/6] ACPI: acpi_video: Remove unnecessary checks Michal Wilczynski
2023-10-25 11:18 ` [PATCH v1 2/6] ACPI: acpi_video: Use yes_or_no helper instead of ternary operator Michal Wilczynski
2023-10-25 11:18 ` [PATCH v1 3/6] ACPI: acpi_video: Remove unnecessary driver_data clear Michal Wilczynski
2023-10-26 12:22 ` Andy Shevchenko [this message]
2023-10-25 11:18 ` [PATCH v1 4/6] ACPI: acpi_video: Replace acpi_driver with platform_driver Michal Wilczynski
2023-10-26 12:24 ` Andy Shevchenko
2023-11-29 14:19 ` Rafael J. Wysocki
2023-12-02 13:20 ` Hans de Goede
2023-10-25 11:18 ` [PATCH v1 5/6] ACPI: acpi_video: Rename ACPI device instances from device to adev Michal Wilczynski
2023-10-25 11:18 ` [PATCH v1 6/6] ACPI: acpi_video: Fix holes in acpi_video_bus Michal Wilczynski
2023-10-26 12:25 ` Andy Shevchenko
2023-10-25 12:56 ` [PATCH v1 0/6] Replace acpi_driver with platform_driver Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTpaAMfDcwaZYO7S@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.wilczynski@intel.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox