From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Michal Wilczynski <michal.wilczynski@intel.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
rafael.j.wysocki@intel.com, lenb@kernel.org
Subject: Re: [PATCH v1 4/6] ACPI: acpi_video: Replace acpi_driver with platform_driver
Date: Thu, 26 Oct 2023 15:24:11 +0300 [thread overview]
Message-ID: <ZTpaa0p7nvR4E4nC@smile.fi.intel.com> (raw)
In-Reply-To: <20231025111806.2416524-5-michal.wilczynski@intel.com>
On Wed, Oct 25, 2023 at 02:18:04PM +0300, Michal Wilczynski wrote:
> The acpi_video driver uses struct acpi_driver to register itself while it
> would be more logically consistent to use struct platform_driver for this
> purpose, because the corresponding platform device is present and the
> role of struct acpi_device is to amend the other bus types. ACPI devices
> are not meant to be used as proper representation of hardware entities,
> but to collect information on those hardware entities provided by the
> platform firmware.
>
> Use struct platform_driver for registering the acpi_video driver.
...
> #include <linux/dmi.h>
> #include <linux/suspend.h>
> #include <linux/acpi.h>
> +#include <linux/platform_device.h>
> #include <acpi/video.h>
> #include <linux/uaccess.h>
Despite this being unsorted I would squeeze to the most sorted part of it,
i.e. with the given context the new inclusion is good to have after dmi.h
(but in full context it might be even better spot).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-10-26 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 11:18 [PATCH v1 0/6] Replace acpi_driver with platform_driver Michal Wilczynski
2023-10-25 11:18 ` [PATCH v1 1/6] ACPI: acpi_video: Remove unnecessary checks Michal Wilczynski
2023-10-25 11:18 ` [PATCH v1 2/6] ACPI: acpi_video: Use yes_or_no helper instead of ternary operator Michal Wilczynski
2023-10-25 11:18 ` [PATCH v1 3/6] ACPI: acpi_video: Remove unnecessary driver_data clear Michal Wilczynski
2023-10-26 12:22 ` Andy Shevchenko
2023-10-25 11:18 ` [PATCH v1 4/6] ACPI: acpi_video: Replace acpi_driver with platform_driver Michal Wilczynski
2023-10-26 12:24 ` Andy Shevchenko [this message]
2023-11-29 14:19 ` Rafael J. Wysocki
2023-12-02 13:20 ` Hans de Goede
2023-10-25 11:18 ` [PATCH v1 5/6] ACPI: acpi_video: Rename ACPI device instances from device to adev Michal Wilczynski
2023-10-25 11:18 ` [PATCH v1 6/6] ACPI: acpi_video: Fix holes in acpi_video_bus Michal Wilczynski
2023-10-26 12:25 ` Andy Shevchenko
2023-10-25 12:56 ` [PATCH v1 0/6] Replace acpi_driver with platform_driver Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTpaa0p7nvR4E4nC@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.wilczynski@intel.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox