From: Francesco Dolcini <francesco@dolcini.it>
To: Thorsten Leemhuis <regressions@leemhuis.info>, linux@bigler.io
Cc: Francesco Dolcini <francesco@dolcini.it>,
Stefan Moring <stefan.moring@technolution.nl>,
Linux regressions mailing list <regressions@lists.linux.dev>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: spi: imx: Increase imx51 ecspi burst length fails on imx6dl and imx8mm
Date: Tue, 21 Nov 2023 10:16:57 +0100 [thread overview]
Message-ID: <ZVx1ic9/vxDDStoE@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <90abbd7a-e3e3-42c9-9be9-28e475f0fc9a@leemhuis.info>
On Tue, Nov 21, 2023 at 10:06:51AM +0100, Thorsten Leemhuis wrote:
> On 20.11.23 18:48, Francesco Dolcini wrote:
> > On Mon, Nov 20, 2023 at 04:30:15PM +0100, Stefan Moring wrote:
> >> Can you verify the values used for the transfer, spi_imx->count and spi_imx->
> >> bits_per_word inside the mx51_ecpsi_prepare_transfer() method? Those are the
> >> only two things that changed in the commits. Maybe compare them to the working
> >> version?
> >
> > I would suggest to bisect the issue to the actual commit that
> > introduced the regression, I do not think this was done yet.
>
> I think it was. To quote
Whoops, you are right.
> spi: Increase imx51 ecspi burst length based on transfer length
> 15a6af94a2779d5dfb42ee4bfac858ea8e964a3f
>
> spi: imx: Take in account bits per word instead of assuming 8-bits
> 5f66db08cbd3ca471c66bacb0282902c79db9274
Do we know which one of those two commits introduces this regression?
Francesco
next prev parent reply other threads:[~2023-11-21 9:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 14:25 spi: imx: Increase imx51 ecspi burst length fails on imx6dl and imx8mm linux
2023-11-18 15:13 ` Linux regression tracking (Thorsten Leemhuis)
2023-11-18 15:15 ` Thorsten Leemhuis
[not found] ` <CAB3BuKA+qOY+UhWR-9Ov3qsz3wQr8q8n38MrEMf3FMCthr04yA@mail.gmail.com>
2023-11-18 17:59 ` linux
[not found] ` <CAB3BuKARgJhaVNFsP1FQ+2yLe18QU9H17fHKjc-Sf3izE+MZ1Q@mail.gmail.com>
2023-11-20 8:27 ` linux
2023-11-20 8:47 ` Francesco Dolcini
2023-11-20 9:33 ` linux
2023-11-20 10:17 ` Francesco Dolcini
[not found] ` <CAB3BuKDb6uucujD7ac-w4pa1GVNLSQUA4OGE7i074mQSU==WaA@mail.gmail.com>
2023-11-20 16:45 ` linux
2023-11-20 17:48 ` Francesco Dolcini
2023-11-21 9:06 ` Thorsten Leemhuis
2023-11-21 9:16 ` Francesco Dolcini [this message]
2023-11-21 10:10 ` Francesco Dolcini
2023-11-21 10:34 ` linux
2023-11-22 13:26 ` linux
2023-11-25 22:44 ` Benjamin Bigler
2023-11-26 13:19 ` Benjamin Bigler
2023-11-27 9:09 ` linux
2023-12-05 13:36 ` Linux regression tracking (Thorsten Leemhuis)
2023-12-07 19:43 ` Benjamin Bigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVx1ic9/vxDDStoE@francesco-nb.int.toradex.com \
--to=francesco@dolcini.it \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@bigler.io \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=stefan.moring@technolution.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox