From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, "Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>
Subject: Re: [rft, PATCH v1 1/1] pinctrl: qcom: lpass-lpi: Remove unused member in struct lpi_pingroup
Date: Tue, 21 Nov 2023 19:15:33 +0200 [thread overview]
Message-ID: <ZVzltQByY1Z0pOGI@smile.fi.intel.com> (raw)
In-Reply-To: <c622c2a5-665f-4ee3-b3dd-fafb3adf6191@linaro.org>
On Tue, Nov 21, 2023 at 08:14:09AM +0100, Krzysztof Kozlowski wrote:
> On 20/11/2023 20:26, Andy Shevchenko wrote:
> > The group is not used anywhere, remove it. And if needed, it should be
> > struct pingroup anyway.
> >
> > While at it, replace kernel.h with what exactly being used.
>
> Missing Reported-by and Closes by for LKP... Unless you discovered it
> without its report?
It's just at hand discovery.
> Missing sm8550.
And sm8650, but there LPI_FUNCTION(gpio) and I'm wondering why LKP complains
about it. It's really a maze to me.
> > #define LPI_PINGROUP(id, soff, f1, f2, f3, f4) \
> > { \
> > - .group.name = "gpio" #id, \
> > - .group.pins = gpio##id##_pins, \
>
> Aren't these used by core pinctrl code?
Only via APIs and pin control registered them also via APIs, so I don't think
this is being used directly. But if you see how, tell me! I spent already a few
hours on this and haven't got any clear picture in my mind.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-21 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 19:26 [rft, PATCH v1 1/1] pinctrl: qcom: lpass-lpi: Remove unused member in struct lpi_pingroup Andy Shevchenko
2023-11-20 23:39 ` kernel test robot
2023-11-21 3:47 ` kernel test robot
2023-11-21 7:14 ` Krzysztof Kozlowski
2023-11-21 17:15 ` Andy Shevchenko [this message]
2023-11-22 15:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVzltQByY1Z0pOGI@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox