* fs/smb/client/sess.c:462:20: warning: duplicated ‘if’ condition
@ 2023-12-28 11:35 David Binderman
2023-12-28 11:52 ` Bagas Sanjaya
0 siblings, 1 reply; 4+ messages in thread
From: David Binderman @ 2023-12-28 11:35 UTC (permalink / raw)
To: sfrench@samba.org, pc@manguebit.com, lsahlber@redhat.com,
sprasad@microsoft.com, tom@talpey.com, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, Linux Kernel Mailing List
Hello there,
Recent development versions of gcc compiler produce the above warning
in linux-6.7-rc7.
Source code is
if (old_iface) {
....
} else if (old_iface) {
Regards
David Binderman
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: fs/smb/client/sess.c:462:20: warning: duplicated ‘if’ condition
2023-12-28 11:35 fs/smb/client/sess.c:462:20: warning: duplicated ‘if’ condition David Binderman
@ 2023-12-28 11:52 ` Bagas Sanjaya
2023-12-28 12:03 ` David Binderman
0 siblings, 1 reply; 4+ messages in thread
From: Bagas Sanjaya @ 2023-12-28 11:52 UTC (permalink / raw)
To: David Binderman, sfrench@samba.org, pc@manguebit.com,
lsahlber@redhat.com, sprasad@microsoft.com, tom@talpey.com,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
On Thu, Dec 28, 2023 at 11:35:29AM +0000, David Binderman wrote:
> Hello there,
>
> Recent development versions of gcc compiler produce the above warning
> in linux-6.7-rc7.
>
> Source code is
>
> if (old_iface) {
> ....
> } else if (old_iface) {
What warnings? And what gcc version? gcc 14?
Confused...
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: fs/smb/client/sess.c:462:20: warning: duplicated ‘if’ condition
2023-12-28 11:52 ` Bagas Sanjaya
@ 2023-12-28 12:03 ` David Binderman
2023-12-28 12:51 ` Bagas Sanjaya
0 siblings, 1 reply; 4+ messages in thread
From: David Binderman @ 2023-12-28 12:03 UTC (permalink / raw)
To: Bagas Sanjaya, sfrench@samba.org, pc@manguebit.com,
lsahlber@redhat.com, sprasad@microsoft.com, tom@talpey.com,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
Linux Kernel Mailing List
Hello there,
>What warnings?
The warning mentioned in the title.
>And what gcc version?
Probably most versions.
You will probably have to switch on gcc compiler flag -Wduplicated-cond
in any random released version of gcc to see what I see.
Regards
David Binderman
Confused...
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: fs/smb/client/sess.c:462:20: warning: duplicated ‘if’ condition
2023-12-28 12:03 ` David Binderman
@ 2023-12-28 12:51 ` Bagas Sanjaya
0 siblings, 0 replies; 4+ messages in thread
From: Bagas Sanjaya @ 2023-12-28 12:51 UTC (permalink / raw)
To: David Binderman, sfrench@samba.org, pc@manguebit.com,
lsahlber@redhat.com, sprasad@microsoft.com, tom@talpey.com,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
On Thu, Dec 28, 2023 at 12:03:21PM +0000, David Binderman wrote:
> Hello there,
>
> >What warnings?
>
> The warning mentioned in the title.
>
> >And what gcc version?
>
> Probably most versions.
So gcc 13 doesn't have the warning but gcc 14 (still in development) do,
right?
>
> You will probably have to switch on gcc compiler flag -Wduplicated-cond
> in any random released version of gcc to see what I see.
Full gcc output please?
Still confused...
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-28 12:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-28 11:35 fs/smb/client/sess.c:462:20: warning: duplicated ‘if’ condition David Binderman
2023-12-28 11:52 ` Bagas Sanjaya
2023-12-28 12:03 ` David Binderman
2023-12-28 12:51 ` Bagas Sanjaya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox