Re: [PATCH] x86/setup: remove duplicated including

[Wang Jinchao <wangjinchao@xfusion.com>]

On Mon, Dec 18, 2023 at 05:27:46PM +0530, Sohil Mehta wrote:
> How about rewording the above to?
> 
> "x86/setup: Remove duplicate header includes"
> 
> On 12/15/2023 3:25 PM, Wang Jinchao wrote:
> > rm the second #include <asm/efi.h> in setup.c
> 
> > rm the second #include <asm/spec-ctrl.h> in smpboot.c
> 
> Actually, these two lines are evident from the diff itself. You can
> remove both of them. If you really want to have some text in the commit
> message you can probably just say:
> 
> efi.h and spec-ctrl.h are included twice. Remove the duplicate entries.
> 
> > 
> > Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com>
> > ---
> >  arch/x86/kernel/setup.c   | 1 -
> >  arch/x86/kernel/smpboot.c | 1 -
> >  2 files changed, 2 deletions(-)
> > 
> 
> With the above changes, please feel free to add:
> 
> Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>
> 
Thanks for the suggestion, which has been applied to the v2 patch.