From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Kent Gibson <warthog618@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [RFC PATCH] gpiolib: remove extra_checks
Date: Wed, 20 Dec 2023 16:03:29 +0200 [thread overview]
Message-ID: <ZYL0MWAQ-frYLnZq@smile.fi.intel.com> (raw)
In-Reply-To: <20231219201102.41639-1-brgl@bgdev.pl>
On Tue, Dec 19, 2023 at 09:11:02PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> extra_checks is only used in a few places. It also depends on
> a non-standard DEBUG define one needs to add to the source file.
Huh?!
What then CONFIG_DEBUG_GPIO is about?
> The
> overhead of removing it should be minimal (we already use pure
> might_sleep() in the code anyway) so drop it.
...
I agree on might_sleep() changes, but WARN_ON(), see above why.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-20 14:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 20:11 [RFC PATCH] gpiolib: remove extra_checks Bartosz Golaszewski
2023-12-20 11:35 ` Linus Walleij
2023-12-20 14:03 ` Andy Shevchenko [this message]
2023-12-20 14:08 ` Bartosz Golaszewski
2023-12-20 15:28 ` Linus Walleij
2023-12-21 9:26 ` Bartosz Golaszewski
2023-12-21 12:52 ` Andy Shevchenko
2023-12-21 13:00 ` Bartosz Golaszewski
2023-12-21 16:13 ` Andy Shevchenko
2023-12-21 18:50 ` Bartosz Golaszewski
2023-12-27 14:59 ` Bartosz Golaszewski
2024-01-16 18:23 ` Guenter Roeck
2024-01-16 21:41 ` Bartosz Golaszewski
2024-01-16 22:34 ` Guenter Roeck
2024-01-17 8:51 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYL0MWAQ-frYLnZq@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox