* [PATCH next] usb: typec: class: Unlocked on error in typec_register_partner()
@ 2025-04-15 10:45 Dan Carpenter
2025-04-15 10:53 ` Heikki Krogerus
2025-04-22 12:44 ` Andrei Kuchynski
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-04-15 10:45 UTC (permalink / raw)
To: Andrei Kuchynski
Cc: Heikki Krogerus, Greg Kroah-Hartman, Benson Leung, linux-usb,
linux-kernel, kernel-janitors
We recently added some locking to this function but this error path
was accidentally missed. Unlock before returning.
Fixes: ec27386de23a ("usb: typec: class: Fix NULL pointer access")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/usb/typec/class.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index 3df3e3736916..67a533e35150 100644
--- a/drivers/usb/typec/class.c
+++ b/drivers/usb/typec/class.c
@@ -1056,6 +1056,7 @@ struct typec_partner *typec_register_partner(struct typec_port *port,
ret = device_register(&partner->dev);
if (ret) {
dev_err(&port->dev, "failed to register partner (%d)\n", ret);
+ mutex_unlock(&port->partner_link_lock);
put_device(&partner->dev);
return ERR_PTR(ret);
}
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH next] usb: typec: class: Unlocked on error in typec_register_partner()
2025-04-15 10:45 [PATCH next] usb: typec: class: Unlocked on error in typec_register_partner() Dan Carpenter
@ 2025-04-15 10:53 ` Heikki Krogerus
2025-04-22 12:44 ` Andrei Kuchynski
1 sibling, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2025-04-15 10:53 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andrei Kuchynski, Greg Kroah-Hartman, Benson Leung, linux-usb,
linux-kernel, kernel-janitors
On Tue, Apr 15, 2025 at 01:45:08PM +0300, Dan Carpenter wrote:
> We recently added some locking to this function but this error path
> was accidentally missed. Unlock before returning.
>
> Fixes: ec27386de23a ("usb: typec: class: Fix NULL pointer access")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/class.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index 3df3e3736916..67a533e35150 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1056,6 +1056,7 @@ struct typec_partner *typec_register_partner(struct typec_port *port,
> ret = device_register(&partner->dev);
> if (ret) {
> dev_err(&port->dev, "failed to register partner (%d)\n", ret);
> + mutex_unlock(&port->partner_link_lock);
> put_device(&partner->dev);
> return ERR_PTR(ret);
> }
> --
> 2.47.2
>
--
heikki
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH next] usb: typec: class: Unlocked on error in typec_register_partner()
2025-04-15 10:45 [PATCH next] usb: typec: class: Unlocked on error in typec_register_partner() Dan Carpenter
2025-04-15 10:53 ` Heikki Krogerus
@ 2025-04-22 12:44 ` Andrei Kuchynski
1 sibling, 0 replies; 3+ messages in thread
From: Andrei Kuchynski @ 2025-04-22 12:44 UTC (permalink / raw)
To: Dan Carpenter
Cc: Heikki Krogerus, Greg Kroah-Hartman, Benson Leung, linux-usb,
linux-kernel, kernel-janitors
On Tue, Apr 15, 2025 at 12:45 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
> We recently added some locking to this function but this error path
> was accidentally missed. Unlock before returning.
>
> Fixes: ec27386de23a ("usb: typec: class: Fix NULL pointer access")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Andrei Kuchynski <akuchynski@chromium.org>
> ---
> drivers/usb/typec/class.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index 3df3e3736916..67a533e35150 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1056,6 +1056,7 @@ struct typec_partner *typec_register_partner(struct typec_port *port,
> ret = device_register(&partner->dev);
> if (ret) {
> dev_err(&port->dev, "failed to register partner (%d)\n", ret);
> + mutex_unlock(&port->partner_link_lock);
> put_device(&partner->dev);
> return ERR_PTR(ret);
> }
> --
> 2.47.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-22 12:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-15 10:45 [PATCH next] usb: typec: class: Unlocked on error in typec_register_partner() Dan Carpenter
2025-04-15 10:53 ` Heikki Krogerus
2025-04-22 12:44 ` Andrei Kuchynski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox