* [RESEND PATCH] crypto: x509 - Replace kmalloc() + NUL-termination with kzalloc()
@ 2025-04-07 8:22 Thorsten Blum
2025-04-07 8:39 ` Lukas Wunner
2025-04-16 7:54 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Thorsten Blum @ 2025-04-07 8:22 UTC (permalink / raw)
To: David Howells, Lukas Wunner, Ignat Korchagin, Herbert Xu,
David S. Miller
Cc: Thorsten Blum, keyrings, linux-crypto, linux-kernel
Use kzalloc() to zero out the one-element array instead of using
kmalloc() followed by a manual NUL-termination.
No functional changes intended.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
crypto/asymmetric_keys/x509_cert_parser.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/crypto/asymmetric_keys/x509_cert_parser.c b/crypto/asymmetric_keys/x509_cert_parser.c
index ee2fdab42334..2ffe4ae90bea 100644
--- a/crypto/asymmetric_keys/x509_cert_parser.c
+++ b/crypto/asymmetric_keys/x509_cert_parser.c
@@ -372,10 +372,9 @@ static int x509_fabricate_name(struct x509_parse_context *ctx, size_t hdrlen,
/* Empty name string if no material */
if (!ctx->cn_size && !ctx->o_size && !ctx->email_size) {
- buffer = kmalloc(1, GFP_KERNEL);
+ buffer = kzalloc(1, GFP_KERNEL);
if (!buffer)
return -ENOMEM;
- buffer[0] = 0;
goto done;
}
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RESEND PATCH] crypto: x509 - Replace kmalloc() + NUL-termination with kzalloc()
2025-04-07 8:22 [RESEND PATCH] crypto: x509 - Replace kmalloc() + NUL-termination with kzalloc() Thorsten Blum
@ 2025-04-07 8:39 ` Lukas Wunner
2025-04-16 7:54 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Lukas Wunner @ 2025-04-07 8:39 UTC (permalink / raw)
To: Thorsten Blum
Cc: David Howells, Ignat Korchagin, Herbert Xu, David S. Miller,
keyrings, linux-crypto, linux-kernel
On Mon, Apr 07, 2025 at 10:22:47AM +0200, Thorsten Blum wrote:
> Use kzalloc() to zero out the one-element array instead of using
> kmalloc() followed by a manual NUL-termination.
>
> No functional changes intended.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH] crypto: x509 - Replace kmalloc() + NUL-termination with kzalloc()
2025-04-07 8:22 [RESEND PATCH] crypto: x509 - Replace kmalloc() + NUL-termination with kzalloc() Thorsten Blum
2025-04-07 8:39 ` Lukas Wunner
@ 2025-04-16 7:54 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2025-04-16 7:54 UTC (permalink / raw)
To: Thorsten Blum
Cc: David Howells, Lukas Wunner, Ignat Korchagin, David S. Miller,
keyrings, linux-crypto, linux-kernel
On Mon, Apr 07, 2025 at 10:22:47AM +0200, Thorsten Blum wrote:
> Use kzalloc() to zero out the one-element array instead of using
> kmalloc() followed by a manual NUL-termination.
>
> No functional changes intended.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> crypto/asymmetric_keys/x509_cert_parser.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-16 7:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-07 8:22 [RESEND PATCH] crypto: x509 - Replace kmalloc() + NUL-termination with kzalloc() Thorsten Blum
2025-04-07 8:39 ` Lukas Wunner
2025-04-16 7:54 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox