* [PATCH v1 1/1] coresight: cti: Replace inclusion by struct fwnode_handle forward declaration
@ 2025-03-31 7:14 Andy Shevchenko
2025-03-31 13:40 ` James Clark
2025-05-08 13:32 ` Suzuki K Poulose
0 siblings, 2 replies; 6+ messages in thread
From: Andy Shevchenko @ 2025-03-31 7:14 UTC (permalink / raw)
To: coresight, linux-arm-kernel, linux-kernel
Cc: Suzuki K Poulose, Mike Leach, James Clark, Alexander Shishkin,
Andy Shevchenko
The fwnode.h is not supposed to be used by the drivers as it
has the definitions for the core parts for different device
property provider implementations. Drop it.
Since the code wants to use the pointer to the struct fwnode_handle
the forward declaration is provided.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/hwtracing/coresight/coresight-cti.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-cti.h b/drivers/hwtracing/coresight/coresight-cti.h
index 16e310e7e9d4..8362a47c939c 100644
--- a/drivers/hwtracing/coresight/coresight-cti.h
+++ b/drivers/hwtracing/coresight/coresight-cti.h
@@ -9,7 +9,6 @@
#include <linux/coresight.h>
#include <linux/device.h>
-#include <linux/fwnode.h>
#include <linux/list.h>
#include <linux/spinlock.h>
#include <linux/sysfs.h>
@@ -17,6 +16,8 @@
#include "coresight-priv.h"
+struct fwnode_handle;
+
/*
* Device registers
* 0x000 - 0x144: CTI programming and status
--
2.47.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] coresight: cti: Replace inclusion by struct fwnode_handle forward declaration
2025-03-31 7:14 [PATCH v1 1/1] coresight: cti: Replace inclusion by struct fwnode_handle forward declaration Andy Shevchenko
@ 2025-03-31 13:40 ` James Clark
2025-04-14 10:06 ` Andy Shevchenko
2025-05-08 13:32 ` Suzuki K Poulose
1 sibling, 1 reply; 6+ messages in thread
From: James Clark @ 2025-03-31 13:40 UTC (permalink / raw)
To: Andy Shevchenko, Suzuki K Poulose
Cc: Mike Leach, Alexander Shishkin, coresight, linux-arm-kernel,
linux-kernel
On 31/03/2025 8:14 am, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
>
> Since the code wants to use the pointer to the struct fwnode_handle
> the forward declaration is provided.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/hwtracing/coresight/coresight-cti.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-cti.h b/drivers/hwtracing/coresight/coresight-cti.h
> index 16e310e7e9d4..8362a47c939c 100644
> --- a/drivers/hwtracing/coresight/coresight-cti.h
> +++ b/drivers/hwtracing/coresight/coresight-cti.h
> @@ -9,7 +9,6 @@
>
> #include <linux/coresight.h>
> #include <linux/device.h>
> -#include <linux/fwnode.h>
> #include <linux/list.h>
> #include <linux/spinlock.h>
> #include <linux/sysfs.h>
> @@ -17,6 +16,8 @@
>
> #include "coresight-priv.h"
>
> +struct fwnode_handle;
> +
> /*
> * Device registers
> * 0x000 - 0x144: CTI programming and status
Reviewed-by: James Clark <james.clark@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] coresight: cti: Replace inclusion by struct fwnode_handle forward declaration
2025-03-31 13:40 ` James Clark
@ 2025-04-14 10:06 ` Andy Shevchenko
2025-04-14 11:00 ` Suzuki K Poulose
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2025-04-14 10:06 UTC (permalink / raw)
To: James Clark
Cc: Suzuki K Poulose, Mike Leach, Alexander Shishkin, coresight,
linux-arm-kernel, linux-kernel
On Mon, Mar 31, 2025 at 02:40:51PM +0100, James Clark wrote:
> On 31/03/2025 8:14 am, Andy Shevchenko wrote:
> Reviewed-by: James Clark <james.clark@linaro.org>
Thank you! Can it be applied now?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] coresight: cti: Replace inclusion by struct fwnode_handle forward declaration
2025-04-14 10:06 ` Andy Shevchenko
@ 2025-04-14 11:00 ` Suzuki K Poulose
2025-05-02 14:12 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Suzuki K Poulose @ 2025-04-14 11:00 UTC (permalink / raw)
To: Andy Shevchenko, James Clark
Cc: Mike Leach, Alexander Shishkin, coresight, linux-arm-kernel,
linux-kernel
On 14/04/2025 11:06, Andy Shevchenko wrote:
> On Mon, Mar 31, 2025 at 02:40:51PM +0100, James Clark wrote:
>> On 31/03/2025 8:14 am, Andy Shevchenko wrote:
>
>> Reviewed-by: James Clark <james.clark@linaro.org>
>
> Thank you! Can it be applied now?
>
I will queue this via coresight tree, for v6.16
Cheers
Suzuki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] coresight: cti: Replace inclusion by struct fwnode_handle forward declaration
2025-04-14 11:00 ` Suzuki K Poulose
@ 2025-05-02 14:12 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2025-05-02 14:12 UTC (permalink / raw)
To: Suzuki K Poulose
Cc: James Clark, Mike Leach, Alexander Shishkin, coresight,
linux-arm-kernel, linux-kernel
On Mon, Apr 14, 2025 at 12:00:49PM +0100, Suzuki K Poulose wrote:
> On 14/04/2025 11:06, Andy Shevchenko wrote:
> > On Mon, Mar 31, 2025 at 02:40:51PM +0100, James Clark wrote:
> > > On 31/03/2025 8:14 am, Andy Shevchenko wrote:
> >
> > > Reviewed-by: James Clark <james.clark@linaro.org>
> >
> > Thank you! Can it be applied now?
>
> I will queue this via coresight tree, for v6.16
I still don't see it in Linux Next, what did I miss?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] coresight: cti: Replace inclusion by struct fwnode_handle forward declaration
2025-03-31 7:14 [PATCH v1 1/1] coresight: cti: Replace inclusion by struct fwnode_handle forward declaration Andy Shevchenko
2025-03-31 13:40 ` James Clark
@ 2025-05-08 13:32 ` Suzuki K Poulose
1 sibling, 0 replies; 6+ messages in thread
From: Suzuki K Poulose @ 2025-05-08 13:32 UTC (permalink / raw)
To: coresight, linux-arm-kernel, linux-kernel, Andy Shevchenko
Cc: Suzuki K Poulose, Mike Leach, James Clark, Alexander Shishkin
On Mon, 31 Mar 2025 10:14:53 +0300, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
>
> Since the code wants to use the pointer to the struct fwnode_handle
> the forward declaration is provided.
>
> [...]
Applied, thanks!
[1/1] coresight: cti: Replace inclusion by struct fwnode_handle forward declaration
https://git.kernel.org/coresight/c/aad548a9
Best regards,
--
Suzuki K Poulose <suzuki.poulose@arm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-05-08 13:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-31 7:14 [PATCH v1 1/1] coresight: cti: Replace inclusion by struct fwnode_handle forward declaration Andy Shevchenko
2025-03-31 13:40 ` James Clark
2025-04-14 10:06 ` Andy Shevchenko
2025-04-14 11:00 ` Suzuki K Poulose
2025-05-02 14:12 ` Andy Shevchenko
2025-05-08 13:32 ` Suzuki K Poulose
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).