* Re: [PATCH v2] parse: handle __cleanup__ attribute [not found] ` <troz4beymvsw2m4y4ocghwiidohi4nbj45ry2tfmbekanu2ray@ooravawiynxr> @ 2024-01-17 20:20 ` Dmitry Torokhov 2024-02-29 14:03 ` Andy Shevchenko 0 siblings, 1 reply; 2+ messages in thread From: Dmitry Torokhov @ 2024-01-17 20:20 UTC (permalink / raw) To: Luc Van Oostenryck Cc: Dan Carpenter, Luc Van Oostenryck, linux-sparse, Peter Zijlstra, linux-kernel Hi, On Mon, Dec 18, 2023 at 02:51:32PM +0100, Luc Van Oostenryck wrote: > On Thu, Dec 14, 2023 at 04:20:20PM +0300, Dan Carpenter wrote: > > Yep. Perfect. Thanks so much! > > Pushed now. Any chance someone is looking at making context tracking working for code annotated as __cleanup? We already have a bunch of code using constructs like: ... guard(spinlock_irqsave)(&gpio_lock); if (!test_bit(FLAG_REQUESTED, &desc->flags)) return NULL; ... which resuls in: $ make C=1 W=1 drivers/gpio/gpiolib.o CALL scripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC drivers/gpio/gpiolib.o CHECK drivers/gpio/gpiolib.c drivers/gpio/gpiolib.c:2359:6: warning: context imbalance in 'gpiochip_dup_line_label' - different lock contexts for basic block and I expect we'll see more and more of this. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] parse: handle __cleanup__ attribute 2024-01-17 20:20 ` [PATCH v2] parse: handle __cleanup__ attribute Dmitry Torokhov @ 2024-02-29 14:03 ` Andy Shevchenko 0 siblings, 0 replies; 2+ messages in thread From: Andy Shevchenko @ 2024-02-29 14:03 UTC (permalink / raw) To: Dmitry Torokhov, Herve Codina Cc: Luc Van Oostenryck, Dan Carpenter, Luc Van Oostenryck, linux-sparse, Peter Zijlstra, linux-kernel On Wed, Jan 17, 2024 at 12:20:13PM -0800, Dmitry Torokhov wrote: > On Mon, Dec 18, 2023 at 02:51:32PM +0100, Luc Van Oostenryck wrote: > > On Thu, Dec 14, 2023 at 04:20:20PM +0300, Dan Carpenter wrote: > > > Yep. Perfect. Thanks so much! > > > > Pushed now. > > Any chance someone is looking at making context tracking working for > code annotated as __cleanup? We already have a bunch of code using > constructs like: > > ... > guard(spinlock_irqsave)(&gpio_lock); > > if (!test_bit(FLAG_REQUESTED, &desc->flags)) > return NULL; > ... > > which resuls in: > > $ make C=1 W=1 drivers/gpio/gpiolib.o > CALL scripts/checksyscalls.sh > DESCEND objtool > INSTALL libsubcmd_headers > CC drivers/gpio/gpiolib.o > CHECK drivers/gpio/gpiolib.c > drivers/gpio/gpiolib.c:2359:6: warning: context imbalance in 'gpiochip_dup_line_label' - different lock contexts for basic block > > and I expect we'll see more and more of this. +1 here. It's quite annoying for every Linux kernel developer in the world (which are at least 2k of active ones). -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-29 14:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <8d596a06-9f25-4d9f-8282-deb2d03a6b0a@moroto.mountain>
[not found] ` <i4s2gnr6rlq3yhmfiy7lkbsahnaioilksvmx3eocdjfh2434zo@zhxhwwgqpxt2>
[not found] ` <44e22df1-734e-49c5-b20b-4f4cdbce24a6@suswa.mountain>
[not found] ` <75ee8bd3-aa80-46dc-9f0c-874a8f4e9d48@suswa.mountain>
[not found] ` <k6ztyjq24ik24qtsu3aqpipodzgq37i2ko42ag7wzn4t2ryrzf@i4gbxu7kvslt>
[not found] ` <c3884893-44fe-4622-8e8e-576a0bdff19f@suswa.mountain>
[not found] ` <troz4beymvsw2m4y4ocghwiidohi4nbj45ry2tfmbekanu2ray@ooravawiynxr>
2024-01-17 20:20 ` [PATCH v2] parse: handle __cleanup__ attribute Dmitry Torokhov
2024-02-29 14:03 ` Andy Shevchenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox