From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: linux-input@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Input: matrix_keypad - avoid repeatedly converting GPIO to IRQ
Date: Wed, 31 Jan 2024 10:48:28 -0800 [thread overview]
Message-ID: <ZbqV_EqBqppL5pNF@google.com> (raw)
In-Reply-To: <CACMJSetrYPaXOr5abHtP1mjsyH3nB3=6CwxWfviN1BP0rhgEhg@mail.gmail.com>
On Mon, Jan 22, 2024 at 09:19:56AM +0100, Bartosz Golaszewski wrote:
> On Sun, 21 Jan 2024 at 06:32, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> >
> > gpio_to_irq() is getting more expensive and may require sleeping.
>
> This is no longer true, the relevant commit was reverted and I have
> now a working series where I'm using SRCU for lockless list traversal
> so if anything it will actually become cheaper.
>
> > Convert row GPIOs to interrupt numbers once in probe() and use
> > this information when the driver needs to enable or disable given
> > interrupt line.
>
> That being said, I'm not against this change, though this may not be
> very useful after all.
OK, then I'll tone down the patch description and apply.
Thanks.
--
Dmitry
prev parent reply other threads:[~2024-01-31 18:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 5:32 [PATCH 1/3] Input: matrix_keypad - avoid repeatedly converting GPIO to IRQ Dmitry Torokhov
2024-01-21 5:32 ` [PATCH 2/3] Input: matrix_keypad - consolidate handling of clustered interrupt Dmitry Torokhov
2024-01-21 5:32 ` [PATCH 3/3] Input: matrix_keypad - switch to using managed resources Dmitry Torokhov
2024-01-22 8:19 ` [PATCH 1/3] Input: matrix_keypad - avoid repeatedly converting GPIO to IRQ Bartosz Golaszewski
2024-01-31 18:48 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbqV_EqBqppL5pNF@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox