* [PATCH v1] usb: typec: altmodes/displayport: send configure message on sop'
@ 2024-02-23 0:23 RD Babiera
2024-02-26 8:17 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: RD Babiera @ 2024-02-23 0:23 UTC (permalink / raw)
To: rdbabiera, heikki.krogerus, gregkh; +Cc: badhri, linux-usb, linux-kernel
When the port is setting the pin configuration when no configuration is
chosen, the DisplayPort driver will not send Configure to the cable plug
if it's available. Add transition to DP_STATE_CONFIGURE_PRIME.
Fixes: 71ba4fe56656 ("usb: typec: altmodes/displayport: add SOP' support")
Signed-off-by: RD Babiera <rdbabiera@google.com>
---
drivers/usb/typec/altmodes/displayport.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
index 5a80776c7255..867f9796f8a8 100644
--- a/drivers/usb/typec/altmodes/displayport.c
+++ b/drivers/usb/typec/altmodes/displayport.c
@@ -164,7 +164,8 @@ static int dp_altmode_status_update(struct dp_altmode *dp)
} else if (!(con & DP_CONF_CURRENTLY(dp->data.conf))) {
ret = dp_altmode_configure(dp, con);
if (!ret) {
- dp->state = DP_STATE_CONFIGURE;
+ dp->state = dp->plug_prime ? DP_STATE_CONFIGURE_PRIME :
+ DP_STATE_CONFIGURE;
if (dp->hpd != hpd) {
dp->hpd = hpd;
dp->pending_hpd = true;
base-commit: 3bf0514dc6f36f81ee11b1becd977cb87b4c90c6
--
2.44.0.rc0.258.g7320e95886-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] usb: typec: altmodes/displayport: send configure message on sop'
2024-02-23 0:23 [PATCH v1] usb: typec: altmodes/displayport: send configure message on sop' RD Babiera
@ 2024-02-26 8:17 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2024-02-26 8:17 UTC (permalink / raw)
To: RD Babiera; +Cc: gregkh, badhri, linux-usb, linux-kernel
On Fri, Feb 23, 2024 at 12:23:03AM +0000, RD Babiera wrote:
> When the port is setting the pin configuration when no configuration is
> chosen, the DisplayPort driver will not send Configure to the cable plug
> if it's available. Add transition to DP_STATE_CONFIGURE_PRIME.
>
> Fixes: 71ba4fe56656 ("usb: typec: altmodes/displayport: add SOP' support")
> Signed-off-by: RD Babiera <rdbabiera@google.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/altmodes/displayport.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
> index 5a80776c7255..867f9796f8a8 100644
> --- a/drivers/usb/typec/altmodes/displayport.c
> +++ b/drivers/usb/typec/altmodes/displayport.c
> @@ -164,7 +164,8 @@ static int dp_altmode_status_update(struct dp_altmode *dp)
> } else if (!(con & DP_CONF_CURRENTLY(dp->data.conf))) {
> ret = dp_altmode_configure(dp, con);
> if (!ret) {
> - dp->state = DP_STATE_CONFIGURE;
> + dp->state = dp->plug_prime ? DP_STATE_CONFIGURE_PRIME :
> + DP_STATE_CONFIGURE;
> if (dp->hpd != hpd) {
> dp->hpd = hpd;
> dp->pending_hpd = true;
>
> base-commit: 3bf0514dc6f36f81ee11b1becd977cb87b4c90c6
> --
> 2.44.0.rc0.258.g7320e95886-goog
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-26 8:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-23 0:23 [PATCH v1] usb: typec: altmodes/displayport: send configure message on sop' RD Babiera
2024-02-26 8:17 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox