From: Feng Tang <feng.tang@intel.com>
To: Waiman Long <longman@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@intel.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>, <x86@kernel.org>,
<paulmck@kernel.org>, <rui.zhang@intel.com>,
<linux-kernel@vger.kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH] x86/tsc: Use topology_max_packages() to get package number
Date: Mon, 18 Mar 2024 09:57:30 +0800 [thread overview]
Message-ID: <ZfefinwL7jUo+Ly0@feng-clx.sh.intel.com> (raw)
In-Reply-To: <e0d1b16a-2880-4e3f-b3ca-b0b47494014a@redhat.com>
On Sun, Mar 17, 2024 at 10:03:38PM -0400, Waiman Long wrote:
>
> On 3/15/24 07:26, Feng Tang wrote:
> > Commit b50db7095fe0 ("x86/tsc: Disable clocksource watchdog for TSC
> > on qualified platorms") was introduced to solve problem that
> > sometimes TSC clocksource is wrongly judged as unstable by watchdog
> > like 'jiffies', HPET, etc.
> >
> > In it, the hardware package number is a key factor for judging whether
> > to disable the watchdog for TSC, and 'nr_online_nodes' was chosen as
> > an estimation due to it is needed in early boot phase before
> > registering 'tsc-early' clocksource, where all none-boot CPUs are not
>
> "none-boot"? You mean "non-boot". Right?
Yes, you are right. will fix it. non-boot CPU means AP (application
processor) here.
>
> Other than that, the patch looks reasonable to me.
Thanks for the review!
- Feng
> Thanks,
> Longman
>
>
next prev parent reply other threads:[~2024-03-18 2:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 11:26 [PATCH] x86/tsc: Use topology_max_packages() to get package number Feng Tang
2024-03-15 17:58 ` Dave Hansen
2024-03-15 20:51 ` Thomas Gleixner
2024-03-18 1:03 ` Feng Tang
2024-03-17 12:00 ` Zhang, Rui
2024-03-18 1:18 ` Feng Tang
2024-03-18 15:08 ` Dave Hansen
2024-03-18 1:16 ` Feng Tang
2024-03-18 2:03 ` Waiman Long
2024-03-18 1:57 ` Feng Tang [this message]
2024-03-18 16:35 ` Dave Hansen
2024-03-19 2:11 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfefinwL7jUo+Ly0@feng-clx.sh.intel.com \
--to=feng.tang@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox