The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Chuanhong Guo <gch981213@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: option: add support for Fibocom FM650/FG650
Date: Wed, 17 Apr 2024 09:36:26 +0200	[thread overview]
Message-ID: <Zh97-jls0BP5nHnL@hovoldconsulting.com> (raw)
In-Reply-To: <CAJsYDVK+Qy-w_Aa9_ns4zZutBJx1HTxm0467chHh0XkLb-4_tg@mail.gmail.com>

On Mon, Apr 15, 2024 at 10:46:52PM +0800, Chuanhong Guo wrote:
> On Mon, Apr 15, 2024 at 2:46 PM Johan Hovold <johan@kernel.org> wrote:
> > On Tue, Mar 12, 2024 at 02:29:12PM +0800, Chuanhong Guo wrote:

> > > Fibocom FM650/FG650 are 5G modems with ECM/NCM/RNDIS/MBIM modes.
> 
> In all 4 modes, the first serial port is the AT console while the other 3
> appear to be diagnostic interfaces for dumping modem logs.
> 
> > > This patch adds support to all 4 modes.
> >
> > Can you please say something here about what each port (in each mode) is
> > used for?
> 
> Do I need to send a v2 for this?

Generally, yes, but I amended the commit message when applying this
time so no need to send a v2.

Thanks!

Johan

      reply	other threads:[~2024-04-17  7:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12  6:29 [PATCH] USB: serial: option: add support for Fibocom FM650/FG650 Chuanhong Guo
2024-04-15  6:46 ` Johan Hovold
2024-04-15 14:46   ` Chuanhong Guo
2024-04-17  7:36     ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zh97-jls0BP5nHnL@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=gch981213@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox