public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 1/1] regmap: spi: Add missing MODULE_DESCRIPTION()
@ 2024-04-10 20:00 Andy Shevchenko
  2024-04-10 20:05 ` Mark Brown
  0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2024-04-10 20:00 UTC (permalink / raw)
  To: Andy Shevchenko, linux-kernel
  Cc: Mark Brown, Greg Kroah-Hartman, Rafael J. Wysocki

The modpost script is not happy

  WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/base/regmap/regmap-spi.o

because there is a missing module description.

Add it to the module.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/base/regmap/regmap-spi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/base/regmap/regmap-spi.c b/drivers/base/regmap/regmap-spi.c
index 37ab23a9d034..df6087b16e69 100644
--- a/drivers/base/regmap/regmap-spi.c
+++ b/drivers/base/regmap/regmap-spi.c
@@ -165,4 +165,5 @@ struct regmap *__devm_regmap_init_spi(struct spi_device *spi,
 }
 EXPORT_SYMBOL_GPL(__devm_regmap_init_spi);
 
+MODULE_DESCRIPTION("Regmap SPI Module");
 MODULE_LICENSE("GPL");
-- 
2.43.0.rc1.1336.g36b5255a03ac


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 1/1] regmap: spi: Add missing MODULE_DESCRIPTION()
  2024-04-10 20:00 [PATCH v1 1/1] regmap: spi: Add missing MODULE_DESCRIPTION() Andy Shevchenko
@ 2024-04-10 20:05 ` Mark Brown
  2024-04-10 20:12   ` Andy Shevchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2024-04-10 20:05 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: linux-kernel, Greg Kroah-Hartman, Rafael J. Wysocki

[-- Attachment #1: Type: text/plain, Size: 119 bytes --]

On Wed, Apr 10, 2024 at 11:00:31PM +0300, Andy Shevchenko wrote:

> +MODULE_DESCRIPTION("Regmap SPI Module");

regmap.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 1/1] regmap: spi: Add missing MODULE_DESCRIPTION()
  2024-04-10 20:05 ` Mark Brown
@ 2024-04-10 20:12   ` Andy Shevchenko
  2024-04-10 20:16     ` Mark Brown
  0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2024-04-10 20:12 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-kernel, Greg Kroah-Hartman, Rafael J. Wysocki

On Wed, Apr 10, 2024 at 09:05:17PM +0100, Mark Brown wrote:
> On Wed, Apr 10, 2024 at 11:00:31PM +0300, Andy Shevchenko wrote:
> 
> > +MODULE_DESCRIPTION("Regmap SPI Module");
> 
> regmap.

Hmm...

drivers/base/regmap/regmap-i3c.c:59:MODULE_DESCRIPTION("Regmap I3C Module");
drivers/base/regmap/regmap-mdio.c:120:MODULE_DESCRIPTION("Regmap MDIO Module");
drivers/base/regmap/regmap-sdw-mbq.c:100:MODULE_DESCRIPTION("Regmap SoundWire MBQ Module");
drivers/base/regmap/regmap-sdw.c:101:MODULE_DESCRIPTION("Regmap SoundWire Module");
drivers/base/regmap/regmap-spi.c:168:MODULE_DESCRIPTION("Regmap SPI Module");

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 1/1] regmap: spi: Add missing MODULE_DESCRIPTION()
  2024-04-10 20:12   ` Andy Shevchenko
@ 2024-04-10 20:16     ` Mark Brown
  2024-04-10 20:23       ` Andy Shevchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2024-04-10 20:16 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: linux-kernel, Greg Kroah-Hartman, Rafael J. Wysocki

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

On Wed, Apr 10, 2024 at 11:12:43PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 10, 2024 at 09:05:17PM +0100, Mark Brown wrote:

> > regmap.

> Hmm...

> drivers/base/regmap/regmap-i3c.c:59:MODULE_DESCRIPTION("Regmap I3C Module");
> drivers/base/regmap/regmap-mdio.c:120:MODULE_DESCRIPTION("Regmap MDIO Module");
> drivers/base/regmap/regmap-sdw-mbq.c:100:MODULE_DESCRIPTION("Regmap SoundWire MBQ Module");
> drivers/base/regmap/regmap-sdw.c:101:MODULE_DESCRIPTION("Regmap SoundWire Module");
> drivers/base/regmap/regmap-spi.c:168:MODULE_DESCRIPTION("Regmap SPI Module");

Feel free to fix the others as well.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 1/1] regmap: spi: Add missing MODULE_DESCRIPTION()
  2024-04-10 20:16     ` Mark Brown
@ 2024-04-10 20:23       ` Andy Shevchenko
  0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2024-04-10 20:23 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-kernel, Greg Kroah-Hartman, Rafael J. Wysocki

On Wed, Apr 10, 2024 at 09:16:26PM +0100, Mark Brown wrote:
> On Wed, Apr 10, 2024 at 11:12:43PM +0300, Andy Shevchenko wrote:
> > On Wed, Apr 10, 2024 at 09:05:17PM +0100, Mark Brown wrote:
> 
> > > regmap.
> 
> > Hmm...
> 
> > drivers/base/regmap/regmap-i3c.c:59:MODULE_DESCRIPTION("Regmap I3C Module");
> > drivers/base/regmap/regmap-mdio.c:120:MODULE_DESCRIPTION("Regmap MDIO Module");
> > drivers/base/regmap/regmap-sdw-mbq.c:100:MODULE_DESCRIPTION("Regmap SoundWire MBQ Module");
> > drivers/base/regmap/regmap-sdw.c:101:MODULE_DESCRIPTION("Regmap SoundWire Module");
> > drivers/base/regmap/regmap-spi.c:168:MODULE_DESCRIPTION("Regmap SPI Module");
> 
> Feel free to fix the others as well.

OK. Will do in v2.

Btw, any news about PXA2xx cleanup?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-04-10 20:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-10 20:00 [PATCH v1 1/1] regmap: spi: Add missing MODULE_DESCRIPTION() Andy Shevchenko
2024-04-10 20:05 ` Mark Brown
2024-04-10 20:12   ` Andy Shevchenko
2024-04-10 20:16     ` Mark Brown
2024-04-10 20:23       ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox