[PATCH v2] ASoC: tas2781: Fix a warning reported by robot kernel test

[PATCH v2] ASoC: tas2781: Fix a warning reported by robot kernel test

[Shenghao Ding]

Fix a warning reported by robot kernel test that 'fw_entry' in function
'tas2781_load_calibration' is used uninitialized with compiler
sh4-linux-gcc (GCC) 13.2.0, an update of copyright and a correction of the
comments.

Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver")
Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>

---
v2:
 - Describe more what was actually an issue reported by robot kernel test.
 - Correct the subject suffix, ALSA: ASoc/tas2781 --> ASoC: tas2781.
v1:
 - Update the copyright year to 2024
 - tasdevice-fmw.c --> tas2781-fmwlib.c
 - | Reported-by: kernel test robot <lkp@intel.com>
   | Closes: https://lore.kernel.org/oe-kbuild-all/202405021200.YHInjV43-lkp@intel.com/
---
 sound/soc/codecs/tas2781-fmwlib.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c
index 45760fe19523..a6be81adcb83 100644
--- a/sound/soc/codecs/tas2781-fmwlib.c
+++ b/sound/soc/codecs/tas2781-fmwlib.c
@@ -1,8 +1,8 @@
 // SPDX-License-Identifier: GPL-2.0
 //
-// tasdevice-fmw.c -- TASDEVICE firmware support
+// tas2781-fmwlib.c -- TASDEVICE firmware support
 //
-// Copyright 2023 Texas Instruments, Inc.
+// Copyright 2023 - 2024 Texas Instruments, Inc.
 //
 // Author: Shenghao Ding <shenghao-ding@ti.com>
 
@@ -1878,7 +1878,7 @@ int tas2781_load_calibration(void *context, char *file_name,
 {
 	struct tasdevice_priv *tas_priv = (struct tasdevice_priv *)context;
 	struct tasdevice *tasdev = &(tas_priv->tasdevice[i]);
-	const struct firmware *fw_entry;
+	const struct firmware *fw_entry = NULL;
 	struct tasdevice_fw *tas_fmw;
 	struct firmware fmw;
 	int offset = 0;
-- 
2.34.1

Re: [PATCH v2] ASoC: tas2781: Fix a warning reported by robot kernel test

[Andy Shevchenko]

On Sun, May 05, 2024 at 08:23:45PM +0800, Shenghao Ding wrote:
> Fix a warning reported by robot kernel test that 'fw_entry' in function
> 'tas2781_load_calibration' is used uninitialized with compiler
> sh4-linux-gcc (GCC) 13.2.0, an update of copyright and a correction of the
> comments.

...

> -// tasdevice-fmw.c -- TASDEVICE firmware support
> +// tas2781-fmwlib.c -- TASDEVICE firmware support

Exactly a good example why the filename shouldn't be in the file.
Please, remove it completely.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] ASoC: tas2781: Fix a warning reported by robot kernel test

[Mark Brown]

On Sun, 05 May 2024 20:23:45 +0800, Shenghao Ding wrote:
> Fix a warning reported by robot kernel test that 'fw_entry' in function
> 'tas2781_load_calibration' is used uninitialized with compiler
> sh4-linux-gcc (GCC) 13.2.0, an update of copyright and a correction of the
> comments.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: tas2781: Fix a warning reported by robot kernel test
      commit: 1ae14f3520b1a0ad144610a3f592c81a3e81cd1b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark