Re: CVE-2024-26650: platform/x86: p2sb: Allow p2sb_bar() calls during PCI device probe

[Michal Hocko <mhocko@suse.com>]

On Thu 23-05-24 15:51:38, Greg KH wrote:
> On Thu, May 23, 2024 at 04:50:18PM +0800, zhengzucheng wrote:
> > 
> > 在 2024/5/22 3:31, Michal Hocko 写道:
> > > This patch has been reverted in upstream by 03c6284df179 ("Revert
> > > "drm/amd/amdgpu: Fix potential ioremap() memory leaks in
> > > amdgpu_device_init()"") and based on the changelog the CVE should be
> > > rejected.
> > 
> > hi Michal Hocko
> > 
> > This reverted patch was previously used to resolve CVE-2024-35928 ?
> > 
> > so CVE-2024-35928 should be rejected?
> > 
> > 
> > commit 03c6284df179de3a4a6e0684764b1c71d2a405e2
> > Author: Ma Jun <Jun.Ma2@amd.com>
> > Date:   Tue Mar 19 15:24:03 2024 +0800
> > 
> >     Revert "drm/amd/amdgpu: Fix potential ioremap() memory leaks in
> > amdgpu_device_init()"
> > 
> >     This patch causes the following iounmap erorr and calltrace
> >     iounmap: bad address 00000000d0b3631f
> > 
> >     The original patch was unjustified because amdgpu_device_fini_sw() will
> >     always cleanup the rmmio mapping.
> > 
> >     This reverts commit eb4f139888f636614dab3bcce97ff61cefc4b3a7.
> > 
> >     Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
> >     Suggested-by: Christian König <christian.koenig@amd.com>
> >     Reviewed-by: Christian König <christian.koenig@amd.com>
> >     Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> 
> Yes, this should be rejected, I'll go do that now, thanks for pointing
> out the revert, we missed that.

yes, I meant this one indeed! Sorry about the confusion.
-- 
Michal Hocko
SUSE Labs