[PATCH 1/1] kbuild: Fix 'import module' error

[PATCH 1/1] kbuild: Fix 'import module' error

[Adrian Huang]

From: Adrian Huang <ahuang12@lenovo.com>

Commit b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src)
for source directory") only changes 'symlinks'. However, 'cmd_symlink'
is not changed accordingly. This leads to the following error:

Traceback (most recent call last):
  File "/your_kernel_obj/linux/vmlinux-gdb.py",
 line 29, in <module>
    import linux.utils
ModuleNotFoundError: No module named 'linux.utils'

Fix the issue by using $(src) instead of $(srctree)/$(src).

Fixes: b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src) for source directory")
Signed-off-by: Adrian Huang <ahuang12@lenovo.com>
---
 scripts/gdb/linux/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/gdb/linux/Makefile b/scripts/gdb/linux/Makefile
index d77ad9079d0f..fcd32fcf3ae0 100644
--- a/scripts/gdb/linux/Makefile
+++ b/scripts/gdb/linux/Makefile
@@ -5,7 +5,7 @@ ifdef building_out_of_srctree
 symlinks := $(patsubst $(src)/%,%,$(wildcard $(src)/*.py))
 
 quiet_cmd_symlink = SYMLINK $@
-      cmd_symlink = ln -fsn $(patsubst $(obj)/%,$(abspath $(srctree))/$(src)/%,$@) $@
+      cmd_symlink = ln -fsn $(patsubst $(obj)/%,$(abspath $(src))/%,$@) $@
 
 always-y += $(symlinks)
 $(addprefix $(obj)/, $(symlinks)): FORCE
-- 
2.25.1

Re: [PATCH 1/1] kbuild: Fix 'import module' error

[Nicolas Schier]

[-- Attachment #1: Type: text/plain, Size: 1822 bytes --]

On Wed 29 May 2024 23:46:21 GMT, Adrian Huang wrote:
> From: Adrian Huang <ahuang12@lenovo.com>
> 
> Commit b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src)
> for source directory") only changes 'symlinks'. However, 'cmd_symlink'
> is not changed accordingly. This leads to the following error:
> 
> Traceback (most recent call last):
>   File "/your_kernel_obj/linux/vmlinux-gdb.py",
>  line 29, in <module>
>     import linux.utils
> ModuleNotFoundError: No module named 'linux.utils'
> 
> Fix the issue by using $(src) instead of $(srctree)/$(src).
> 
> Fixes: b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src) for source directory")
> Signed-off-by: Adrian Huang <ahuang12@lenovo.com>
> ---
>  scripts/gdb/linux/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/gdb/linux/Makefile b/scripts/gdb/linux/Makefile
> index d77ad9079d0f..fcd32fcf3ae0 100644
> --- a/scripts/gdb/linux/Makefile
> +++ b/scripts/gdb/linux/Makefile
> @@ -5,7 +5,7 @@ ifdef building_out_of_srctree
>  symlinks := $(patsubst $(src)/%,%,$(wildcard $(src)/*.py))
>  
>  quiet_cmd_symlink = SYMLINK $@
> -      cmd_symlink = ln -fsn $(patsubst $(obj)/%,$(abspath $(srctree))/$(src)/%,$@) $@
> +      cmd_symlink = ln -fsn $(patsubst $(obj)/%,$(abspath $(src))/%,$@) $@
>  
>  always-y += $(symlinks)
>  $(addprefix $(obj)/, $(symlinks)): FORCE
> -- 
> 2.25.1

Hi Adrian,

this is already fixed in kbuild/for-next.  Unfortunately the patch is 
not available at lore.kernel.org (did not not pass any usual mailing 
list?), but you can find the pre-applied patch in [1].

Kind regards,
Nicolas

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/commit/?h=for-next&id=659bbf7e1b08267b8e1dd900b316edcb6f6d9e2e

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]