From: Niklas Cassel <cassel@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: ata: ahci-fsl-qoriq: convert to yaml format
Date: Tue, 18 Jun 2024 11:44:25 +0200 [thread overview]
Message-ID: <ZnFW-d1ktgWTZutZ@ryzen.lan> (raw)
In-Reply-To: <20240617180241.901377-1-Frank.Li@nxp.com>
On Mon, Jun 17, 2024 at 02:02:40PM -0400, Frank Li wrote:
> Convert ahci-fsl-qoirq DT binding to yaml format.
>
> Additional changes:
> - Add reg-names list, ahci and sata-ecc
> - Add fsl,ls1028a-ahci and fsl,lx2060a-ahci
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../bindings/ata/ahci-fsl-qoriq.txt | 21 -------
> .../devicetree/bindings/ata/fsl,ahci.yaml | 58 +++++++++++++++++++
> 2 files changed, 58 insertions(+), 21 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
> create mode 100644 Documentation/devicetree/bindings/ata/fsl,ahci.yaml
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
> deleted file mode 100644
> index 7c3ca0e13de05..0000000000000
> --- a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -Binding for Freescale QorIQ AHCI SATA Controller
> -
> -Required properties:
> - - reg: Physical base address and size of the controller's register area.
> - - compatible: Compatibility string. Must be 'fsl,<chip>-ahci', where
> - chip could be ls1021a, ls1043a, ls1046a, ls1088a, ls2080a etc.
> - - clocks: Input clock specifier. Refer to common clock bindings.
> - - interrupts: Interrupt specifier. Refer to interrupt binding.
> -
> -Optional properties:
> - - dma-coherent: Enable AHCI coherent DMA operation.
> - - reg-names: register area names when there are more than 1 register area.
> -
> -Examples:
> - sata@3200000 {
> - compatible = "fsl,ls1021a-ahci";
> - reg = <0x0 0x3200000 0x0 0x10000>;
> - interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&platform_clk 1>;
> - dma-coherent;
> - };
> diff --git a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
> new file mode 100644
> index 0000000000000..162b3bb5427ed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ata/fsl,ahci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale QorIQ AHCI SATA Controller
> +
> +maintainers:
> + - Frank Li <Frank.Li@nxp.com>
> +
> +properties:
> + compatible:
> + enum:
> + - fsl,ls1021a-ahci
> + - fsl,ls1043a-ahci
> + - fsl,ls1028a-ahci
> + - fsl,ls1088a-ahci
> + - fsl,ls2080a-ahci
> + - fsl,lx2160a-ahci
> +
> + reg:
> + minItems: 1
> + maxItems: 2
> +
> + reg-names:
> + items:
> + - const: ahci
> + - const: sata-ecc
> + minItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + dma-coherent: true
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + sata@3200000 {
> + compatible = "fsl,ls1021a-ahci";
> + reg = <0x3200000 0x10000>;
> + interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&platform_clk 1>;
> + dma-coherent;
> + };
> --
> 2.34.1
>
Applied:
https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git/log/?h=for-6.11
prev parent reply other threads:[~2024-06-18 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 18:02 [PATCH 1/1] dt-bindings: ata: ahci-fsl-qoriq: convert to yaml format Frank Li
2024-06-17 19:12 ` Niklas Cassel
2024-06-18 7:42 ` Krzysztof Kozlowski
2024-06-18 8:45 ` Niklas Cassel
2024-06-18 9:13 ` Krzysztof Kozlowski
2024-06-18 7:42 ` Krzysztof Kozlowski
2024-06-18 9:44 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnFW-d1ktgWTZutZ@ryzen.lan \
--to=cassel@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox