Re: [PATCH 1/1] dt-bindings: ata: ahci-fsl-qoriq: convert to yaml format

[Krzysztof Kozlowski <krzk@kernel.org>]

On 18/06/2024 10:45, Niklas Cassel wrote:
> On Tue, Jun 18, 2024 at 09:42:03AM +0200, Krzysztof Kozlowski wrote:
>> On 17/06/2024 21:12, Niklas Cassel wrote:
>>> On Mon, Jun 17, 2024 at 02:02:40PM -0400, Frank Li wrote:
>>>> Convert ahci-fsl-qoirq DT binding to yaml format.
>>>>
>>>> Additional changes:
>>>> - Add reg-names list, ahci and sata-ecc
>>>> - Add fsl,ls1028a-ahci and fsl,lx2060a-ahci
>>>>
>>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>>> ---
>>>>  .../bindings/ata/ahci-fsl-qoriq.txt           | 21 -------
>>>>  .../devicetree/bindings/ata/fsl,ahci.yaml     | 58 +++++++++++++++++++
>>>>  2 files changed, 58 insertions(+), 21 deletions(-)
>>>>  delete mode 100644 Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
>>>>  create mode 100644 Documentation/devicetree/bindings/ata/fsl,ahci.yaml
>>>
>>> Should this file perhaps be called:
>>> fsl,qoriq-ahci.yaml ?
>>>
>>> Would be nice with some input from DT maintainers on this.
>>
>> This should be rather compatible.
> 
> Considering that you gave your Reviewed-by tag, I interpret this sentence
> as that you are happy with the filename used (fsl,ahci.yaml) in this patch.
> 

Yes, maybe indeed fsl,qoriq-ahci or compatible-based would be better,
but probably I provided a bit different review on other patch, so don't
want to block useful conversion.

Best regards,
Krzysztof