From: Dave Martin <Dave.Martin@arm.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
James Morse <james.morse@arm.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
shameerali.kolothum.thodi@huawei.com,
D Scott Phillips OS <scott@os.amperecomputing.com>,
carl@os.amperecomputing.com, lcherian@marvell.com,
bobo.shaobowang@huawei.com,
"Shaopeng Tan (Fujitsu)" <tan.shaopeng@fujitsu.com>,
baolin.wang@linux.alibaba.com,
Jamie Iles <quic_jiles@quicinc.com>,
Xin Hao <xhao@linux.alibaba.com>,
Peter Newman <peternewman@google.com>,
dfustini@baylibre.com, amitsinght@marvell.com,
David Hildenbrand <david@redhat.com>,
Rex Nie <rex.nie@jaguarmicro.com>
Subject: Re: [PATCH] x86/resctrl: Don't try to free nonexistent RMIDs
Date: Wed, 19 Jun 2024 13:54:31 +0100 [thread overview]
Message-ID: <ZnLVB1Cvy8PXhaMv@e133380.arm.com> (raw)
In-Reply-To: <f30c9a16-27b5-44ab-a55d-b2f9f3e4258e@intel.com>
Hi,
On Tue, Jun 18, 2024 at 10:08:47AM -0700, Reinette Chatre wrote:
> Hi Dave,
>
> On 6/18/24 9:16 AM, Dave Martin wrote:
>
> >
> > Either way, I don't think this impacts the tested-ness of this patch,
> > but please shout if you have concerns.
> >
>
> I agree. The submission stated that it was tested on x86
> "for the monitors-present case". When booting with
> "rdt=!cmt,!mbmtotal,!mbmlocal" (as I did in my test) resctrl
> is not able to discover monitoring support and it
> thus tested the "monitors _not_ present case".
>
> Reinette
Ah, right. I missed the significance of the options.
Thanks again!
---Dave
>
>
prev parent reply other threads:[~2024-06-19 12:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 16:08 [PATCH] x86/resctrl: Don't try to free nonexistent RMIDs Dave Martin
2024-06-14 22:47 ` Reinette Chatre
2024-06-17 11:55 ` Dave Martin
2024-06-17 15:53 ` Reinette Chatre
2024-06-18 9:30 ` Dave Martin
2024-06-18 15:43 ` Reinette Chatre
2024-06-18 16:16 ` Dave Martin
2024-06-18 17:08 ` Reinette Chatre
2024-06-19 12:54 ` Dave Martin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnLVB1Cvy8PXhaMv@e133380.arm.com \
--to=dave.martin@arm.com \
--cc=Babu.Moger@amd.com \
--cc=amitsinght@marvell.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bobo.shaobowang@huawei.com \
--cc=bp@alien8.de \
--cc=carl@os.amperecomputing.com \
--cc=david@redhat.com \
--cc=dfustini@baylibre.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peternewman@google.com \
--cc=quic_jiles@quicinc.com \
--cc=reinette.chatre@intel.com \
--cc=rex.nie@jaguarmicro.com \
--cc=scott@os.amperecomputing.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=tan.shaopeng@fujitsu.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xhao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox