From: Reinette Chatre <reinette.chatre@intel.com>
To: Dave Martin <Dave.Martin@arm.com>
Cc: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
James Morse <james.morse@arm.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
<shameerali.kolothum.thodi@huawei.com>,
"D Scott Phillips OS" <scott@os.amperecomputing.com>,
<carl@os.amperecomputing.com>, <lcherian@marvell.com>,
<bobo.shaobowang@huawei.com>,
"Shaopeng Tan (Fujitsu)" <tan.shaopeng@fujitsu.com>,
<baolin.wang@linux.alibaba.com>,
Jamie Iles <quic_jiles@quicinc.com>,
Xin Hao <xhao@linux.alibaba.com>,
Peter Newman <peternewman@google.com>, <dfustini@baylibre.com>,
<amitsinght@marvell.com>, David Hildenbrand <david@redhat.com>,
Rex Nie <rex.nie@jaguarmicro.com>
Subject: Re: [PATCH] x86/resctrl: Don't try to free nonexistent RMIDs
Date: Tue, 18 Jun 2024 08:43:51 -0700 [thread overview]
Message-ID: <d476585b-3cfb-494d-b25c-4aeb6244e21d@intel.com> (raw)
In-Reply-To: <ZnFTnzm/jctgN2wf@e133344.arm.com>
Hi Dave,
On 6/18/24 2:30 AM, Dave Martin wrote:
> On Mon, Jun 17, 2024 at 08:53:38AM -0700, Reinette Chatre wrote:
>> On 6/17/24 4:55 AM, Dave Martin wrote:
>>> As it happens I tested with rdt=cmt,mbmtotal,mbmlocal,l3cat,l3cdp
>>> (though I made no effort to exercise these features other than running
>>> the selftests). I can note this in the commit if you prefer.
>>
>> hmmm ... those parameters should not be necessary unless the system
>> has those features forced off by default because of errata. Doing
>> functional testing on these systems via such enabling is fine
>> though.
>>
>> Reinette
>
> I got these kernel args from James. Apparently some of these features
> are defaulted to off by the firmware on the box I'm using, but we're not
> sure why. I haven't dug into it.
resctrl does not provide capability to override features that the hardware
does not advertise as supporting. resctrl does sometimes force hardware
advertised features off because of errata (for example, see [1]) and the
kernel "rdt=" parameter can be used to override that. This same option also
enables administrators to ignore some features on their platforms.
Reinette
[1] https://lore.kernel.org/all/3aea0a3bae219062c812668bd9b7b8f1a25003ba.1503512900.git.tony.luck@intel.com/
next prev parent reply other threads:[~2024-06-18 15:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 16:08 [PATCH] x86/resctrl: Don't try to free nonexistent RMIDs Dave Martin
2024-06-14 22:47 ` Reinette Chatre
2024-06-17 11:55 ` Dave Martin
2024-06-17 15:53 ` Reinette Chatre
2024-06-18 9:30 ` Dave Martin
2024-06-18 15:43 ` Reinette Chatre [this message]
2024-06-18 16:16 ` Dave Martin
2024-06-18 17:08 ` Reinette Chatre
2024-06-19 12:54 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d476585b-3cfb-494d-b25c-4aeb6244e21d@intel.com \
--to=reinette.chatre@intel.com \
--cc=Babu.Moger@amd.com \
--cc=Dave.Martin@arm.com \
--cc=amitsinght@marvell.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bobo.shaobowang@huawei.com \
--cc=bp@alien8.de \
--cc=carl@os.amperecomputing.com \
--cc=david@redhat.com \
--cc=dfustini@baylibre.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peternewman@google.com \
--cc=quic_jiles@quicinc.com \
--cc=rex.nie@jaguarmicro.com \
--cc=scott@os.amperecomputing.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=tan.shaopeng@fujitsu.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xhao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox