public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Martin <Dave.Martin@arm.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-tip-commits@vger.kernel.org,
	Reinette Chatre <reinette.chatre@intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [tip: x86/urgent] x86/resctrl: Don't try to free nonexistent RMIDs
Date: Wed, 19 Jun 2024 17:03:03 +0100	[thread overview]
Message-ID: <ZnMBN487xiPOfpRp@e133380.arm.com> (raw)
In-Reply-To: <20240619134522.GCZnLg8pgJq9MPHS8M@fat_crate.local>

Hi Boris,

On Wed, Jun 19, 2024 at 03:45:22PM +0200, Borislav Petkov wrote:
> On Wed, Jun 19, 2024 at 01:51:34PM +0100, Dave Martin wrote:
> > This commit message now looks a mess on a regular terminal, since git
> > log indents the start of each line by four columns.
> 
> Well, we got rid of the 80 cols rule a long time ago so if you're looking at
> kernel code in that same terminal, you're looking at a similar mess?

<bikeshed>

It's still a guideline, no?  (Though I admit that common sense has to
apply and there are quite often good reasons to bust the limit in
code.)  But commit messages are not code, and don't suffer from
creeping indentation that eats up half of each line, so the rationale
is not really the same.

In block text, lines near maximum length are common, but when looking at
code OTOH, long lines are usually rare, so the file is not rendered
unreadable without linewrap turned off or a bigger terminal.

For git logs, git config core.pager 'less -S' makes things a little
better I suppose, since that at least keeps the left-hand columns blank
on the commit message lines, making the log easier to skim through by
eye.  There doesn't seem to be a way to bind a key to flip line
wrapping on and off in less at runtime, though I've not dug into it.

</bikeshed>


Anyway, I was just mildly surprised, it's not a huge deal.

> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette

(Quoted: "Text-based e-mail should not exceed 80 columns per line of
text.  Consult the documentation of your e-mail client to enable proper
line breaks around column 78.".  No statement about commit messages,
and "should not exceed" is not the same as "should be wrapped to".
This document doesn't seem to consider how git formats text derived
from emails.)

Cheers
---Dave

  reply	other threads:[~2024-06-19 16:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 14:01 [PATCH v2] x86/resctrl: Don't try to free nonexistent RMIDs Dave Martin
2024-06-19  9:55 ` [tip: x86/urgent] " tip-bot2 for Dave Martin
2024-06-19 12:51   ` Dave Martin
2024-06-19 13:45     ` Borislav Petkov
2024-06-19 16:03       ` Dave Martin [this message]
2024-06-19 16:21         ` Borislav Petkov
2024-06-20 11:36           ` Dave Martin
2024-06-20 11:53             ` Borislav Petkov
2024-06-20 12:38               ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZnMBN487xiPOfpRp@e133380.arm.com \
    --to=dave.martin@arm.com \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox