From: Dave Martin <Dave.Martin@arm.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-tip-commits@vger.kernel.org,
Reinette Chatre <reinette.chatre@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [tip: x86/urgent] x86/resctrl: Don't try to free nonexistent RMIDs
Date: Thu, 20 Jun 2024 13:38:39 +0100 [thread overview]
Message-ID: <ZnQizwOWjsIbj6TR@e133380.arm.com> (raw)
In-Reply-To: <20240620115305.GBZnQYIex1mnXxoG-8@fat_crate.local>
On Thu, Jun 20, 2024 at 01:53:05PM +0200, Borislav Petkov wrote:
> On Thu, Jun 20, 2024 at 12:36:43PM +0100, Dave Martin wrote:
> > I guess my issue is that the "Massage commit message" seems to document
> > a criticism that the author was careless, didn't follow a rule, or that
> > the commit message was defective in some way, with the author having no
> > right of reply (at least, not recorded in the git history).
>
> Not necessarily - that's what you said. I massage commit messages because they
> need some touch ups sometimes.
>
> In your case I rewrote the sentence with "we" because "we" is ambiguous in
That _was_ unintentional, so apologies for that.
> commit messages. I also broke up this biggish paragraph into smaller chunks to
> make it more readable.
>
> > I may just be being too touchy.
> >
> > Anyway, thanks for picking up the patch -- I'm not trying to make extra
> > work for anyone.
>
> I look at it this way: I don't always agree with other maintainers' choices
> either but this is the reality: every maintainer has their own
> requirements/views/etc on how the code and commit messages are going to look,
> yadda yadda. And to some extent that's their prerogative.
>
> But we have a *lot* *bigger* fish to fry so I'm going to stop debating here as
> everything was already said.
>
> Thx.
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
>
Ack; apologies for the noise.
Cheers
---Dave
prev parent reply other threads:[~2024-06-20 12:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 14:01 [PATCH v2] x86/resctrl: Don't try to free nonexistent RMIDs Dave Martin
2024-06-19 9:55 ` [tip: x86/urgent] " tip-bot2 for Dave Martin
2024-06-19 12:51 ` Dave Martin
2024-06-19 13:45 ` Borislav Petkov
2024-06-19 16:03 ` Dave Martin
2024-06-19 16:21 ` Borislav Petkov
2024-06-20 11:36 ` Dave Martin
2024-06-20 11:53 ` Borislav Petkov
2024-06-20 12:38 ` Dave Martin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnQizwOWjsIbj6TR@e133380.arm.com \
--to=dave.martin@arm.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox