The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "André Draszik" <andre.draszik@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Peter Griffin <peter.griffin@linaro.org>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Will McVicker <willmcvicker@google.com>,
	Badhri Jagan Sridharan <badhri@google.com>,
	kernel-team@android.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/15] usb: typec: tcpm/tcpci_maxim: clarify a comment
Date: Wed, 31 Jul 2024 13:10:40 +0300	[thread overview]
Message-ID: <ZqoNoGcCsCwNl1N0@kuha.fi.intel.com> (raw)
In-Reply-To: <20240710-tcpc-cleanup-v1-2-0ec1f41f4263@linaro.org>

On Wed, Jul 10, 2024 at 11:36:09AM +0100, André Draszik wrote:
> We loop while the status is != 0, so rephrase the comment slightly for
> clarity.
> 
> Signed-off-by: André Draszik <andre.draszik@linaro.org>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpci_maxim_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim_core.c b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> index eec3bcec119c..87102b4d060d 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
> @@ -397,7 +397,7 @@ static irqreturn_t max_tcpci_irq(int irq, void *dev_id)
>  	}
>  	while (status) {
>  		irq_return = _max_tcpci_irq(chip, status);
> -		/* Do not return if the ALERT is already set. */
> +		/* Do not return if a (new) ALERT is set (again). */
>  		ret = max_tcpci_read16(chip, TCPC_ALERT, &status);
>  		if (ret < 0)
>  			break;
> 
> -- 
> 2.45.2.803.g4e1b14247a-goog

-- 
heikki

  reply	other threads:[~2024-07-31 10:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10 10:36 [PATCH 00/15] usb: typec: tcpci: few TCPCi & TCPCi-Maxim cleanups (mostly genmask()) André Draszik
2024-07-10 10:36 ` [PATCH 01/15] usb: typec: tcpci: fix a comment typo André Draszik
2024-07-31  9:47   ` Heikki Krogerus
2024-07-10 10:36 ` [PATCH 02/15] usb: typec: tcpm/tcpci_maxim: clarify a comment André Draszik
2024-07-31 10:10   ` Heikki Krogerus [this message]
2024-07-10 10:36 ` [PATCH 03/15] usb: typec: tcpci: use GENMASK() for TCPC_CC_STATUS_CC[12] André Draszik
2024-07-31 10:26   ` Heikki Krogerus
2024-07-10 10:36 ` [PATCH 04/15] usb: typec: tcpci: use GENMASK() for TCPC_ROLE_CTRL_CC[12] André Draszik
2024-07-31 10:28   ` Heikki Krogerus
2024-07-10 10:36 ` [PATCH 05/15] usb: typec: tcpci: use GENMASK() for TCPC_ROLE_CTRL_RP_VAL André Draszik
2024-07-31 10:37   ` Heikki Krogerus
2024-07-10 10:36 ` [PATCH 06/15] usb: typec: tcpci: use GENMASK() for TCPC_MSG_HDR_INFO_REV André Draszik
2024-07-31 10:39   ` Heikki Krogerus
2024-07-10 10:36 ` [PATCH 07/15] usb: typec: tcpci: use GENMASK() for TCPC_TRANSMIT register fields André Draszik
2024-07-31 11:01   ` Heikki Krogerus
2024-07-10 10:36 ` [PATCH 08/15] usb: typec: tcpm/tcpci_maxim: sort TCPC_ALERT_MASK values by bit André Draszik
2024-07-31 11:09   ` Heikki Krogerus
2024-07-10 10:36 ` [PATCH 09/15] usb: typec: tcpm/tcpci_maxim: simplify clearing of TCPC_ALERT_RX_BUF_OVF André Draszik
2024-07-31 11:12   ` Heikki Krogerus
2024-07-10 10:36 ` [PATCH 10/15] usb: typec: tcpm/tcpci_maxim: drop STATUS_CHECK() André Draszik
2024-07-31 12:29   ` Heikki Krogerus
2024-07-10 10:36 ` [PATCH 11/15] usb: typec: tcpm/tcpci_maxim: use GENMASK() for TCPC_VENDOR_CC_CTRL2 register André Draszik
2024-07-31 12:36   ` Heikki Krogerus
2024-07-10 10:36 ` [PATCH 12/15] usb: typec: tcpm/tcpci_maxim: use GENMASK() for TCPC_VENDOR_CC_CTRL3 register André Draszik
2024-07-31 12:38   ` Heikki Krogerus
2024-07-10 10:36 ` [PATCH 13/15] usb: typec: tcpm/tcpci_maxim: use GENMASK() for TCPC_VENDOR_ADC_CTRL1 register André Draszik
2024-07-31 12:40   ` Heikki Krogerus
2024-07-10 10:36 ` [PATCH 14/15] usb: typec: tcpm/tcpci_maxim: convert to dev_err_probe() André Draszik
2024-07-31 12:44   ` Heikki Krogerus
2024-07-10 10:36 ` [PATCH 15/15] usb: typec: tcpm/tcpci_maxim: use device managed TCPCI port deregistration André Draszik
2024-07-31 12:45   ` Heikki Krogerus
2024-07-26  5:59 ` [PATCH 00/15] usb: typec: tcpci: few TCPCi & TCPCi-Maxim cleanups (mostly genmask()) André Draszik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZqoNoGcCsCwNl1N0@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=andre.draszik@linaro.org \
    --cc=badhri@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox