From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: dianders@chromium.org, mhocko@suse.com,
akpm@linux-foundation.org, maz@kernel.org, vschneid@redhat.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: smp: Fix missing backtrace IPI statics
Date: Thu, 1 Aug 2024 17:36:02 +0100 [thread overview]
Message-ID: <Zqu5ck+Ik8KlzE0O@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240801094022.1402616-1-ruanjinjie@huawei.com>
On Thu, Aug 01, 2024 at 05:40:22PM +0800, Jinjie Ruan wrote:
> It is similar to ARM64 commit 916b93f4e865 ("arm64: smp: Fix missing IPI
> statistics"), commit 56afcd3dbd19 ("ARM: Allow IPIs to be handled as normal
> interrupts") set CPU_BACKTRACE IPI "IRQ_HIDDEN" flag but not show it in
> show_ipi_list(), which cause the interrupt kstat_irqs accounting
> is missing in display.
I don't see why this needs to be included. If this IPI fires, it means
that the kernel has suffered a lockup and is probably not very useful.
So the chances of being able to read out from /proc/interrupts a non-
zero "CPU backtrace interrupts" figure is highly unlikely.
So, I don't see much point to this change.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-08-01 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 9:40 [PATCH] ARM: smp: Fix missing backtrace IPI statics Jinjie Ruan
2024-08-01 16:36 ` Russell King (Oracle) [this message]
2024-08-02 1:39 ` Jinjie Ruan
2024-08-02 1:44 ` Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zqu5ck+Ik8KlzE0O@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mhocko@suse.com \
--cc=ruanjinjie@huawei.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox