[PATCH v1 1/1] dimlib: Use *-y instead of *-objs in Makefile

[PATCH v1 1/1] dimlib: Use *-y instead of *-objs in Makefile

[Andy Shevchenko]

*-objs suffix is reserved rather for (user-space) host programs while
usually *-y suffix is used for kernel drivers (although *-objs works
for that purpose for now).

Let's correct the old usages of *-objs in Makefiles.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

Reported by Olek. As I said him this is correct change which is
documented in Documentation/kbuild/makefiles.rst "Composite Host
Programs" (mind the meaning of the word "host"!). 

 lib/dim/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dim/Makefile b/lib/dim/Makefile
index c4cc4026c451..5b9bfaac7ac1 100644
--- a/lib/dim/Makefile
+++ b/lib/dim/Makefile
@@ -4,4 +4,4 @@
 
 obj-$(CONFIG_DIMLIB) += dimlib.o
 
-dimlib-objs := dim.o net_dim.o rdma_dim.o
+dimlib-y := dim.o net_dim.o rdma_dim.o
-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v1 1/1] dimlib: Use *-y instead of *-objs in Makefile

[Alexander Lobakin]

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Wed, 8 May 2024 17:29:42 +0300

> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
> 
> Let's correct the old usages of *-objs in Makefiles.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

> ---
> 
> Reported by Olek. As I said him this is correct change which is
> documented in Documentation/kbuild/makefiles.rst "Composite Host
> Programs" (mind the meaning of the word "host"!). 
> 
>  lib/dim/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/dim/Makefile b/lib/dim/Makefile
> index c4cc4026c451..5b9bfaac7ac1 100644
> --- a/lib/dim/Makefile
> +++ b/lib/dim/Makefile
> @@ -4,4 +4,4 @@
>  
>  obj-$(CONFIG_DIMLIB) += dimlib.o
>  
> -dimlib-objs := dim.o net_dim.o rdma_dim.o
> +dimlib-y := dim.o net_dim.o rdma_dim.o

Thanks,
Olek

Re: [PATCH v1 1/1] dimlib: Use *-y instead of *-objs in Makefile

[Florian Fainelli]

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

On 5/8/24 07:29, Andy Shevchenko wrote:
> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
> 
> Let's correct the old usages of *-objs in Makefiles.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>

> ---
> 
> Reported by Olek. As I said him this is correct change which is
> documented in Documentation/kbuild/makefiles.rst "Composite Host
> Programs" (mind the meaning of the word "host"!).

Why not credit him with an official Reported-by?

> 
>   lib/dim/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/dim/Makefile b/lib/dim/Makefile
> index c4cc4026c451..5b9bfaac7ac1 100644
> --- a/lib/dim/Makefile
> +++ b/lib/dim/Makefile
> @@ -4,4 +4,4 @@
>   
>   obj-$(CONFIG_DIMLIB) += dimlib.o
>   
> -dimlib-objs := dim.o net_dim.o rdma_dim.o
> +dimlib-y := dim.o net_dim.o rdma_dim.o

-- 
Florian


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

Re: [PATCH v1 1/1] dimlib: Use *-y instead of *-objs in Makefile

[Andy Shevchenko]

On Wed, May 08, 2024 at 10:39:55AM -0700, Florian Fainelli wrote:
> On 5/8/24 07:29, Andy Shevchenko wrote:
> > *-objs suffix is reserved rather for (user-space) host programs while
> > usually *-y suffix is used for kernel drivers (although *-objs works
> > for that purpose for now).
> > 
> > Let's correct the old usages of *-objs in Makefiles.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
> 
> > ---
> > 
> > Reported by Olek. As I said him this is correct change which is
> > documented in Documentation/kbuild/makefiles.rst "Composite Host
> > Programs" (mind the meaning of the word "host"!).
> 
> Why not credit him with an official Reported-by?

No problem
Reported-by: Alexander Lobakin <aleksander.lobakin@intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] dimlib: Use *-y instead of *-objs in Makefile

[Andy Shevchenko]

On Wed, May 08, 2024 at 08:50:28PM +0300, Andy Shevchenko wrote:
> On Wed, May 08, 2024 at 10:39:55AM -0700, Florian Fainelli wrote:
> > On 5/8/24 07:29, Andy Shevchenko wrote:
> > > *-objs suffix is reserved rather for (user-space) host programs while
> > > usually *-y suffix is used for kernel drivers (although *-objs works
> > > for that purpose for now).
> > > 
> > > Let's correct the old usages of *-objs in Makefiles.
> > > 
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > 
> > Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
> > 

> > > 
> > > Reported by Olek. As I said him this is correct change which is
> > > documented in Documentation/kbuild/makefiles.rst "Composite Host
> > > Programs" (mind the meaning of the word "host"!).
> > 
> > Why not credit him with an official Reported-by?
> 
> No problem
> Reported-by: Alexander Lobakin <aleksander.lobakin@intel.com>

Who is going to apply this?

-- 
With Best Regards,
Andy Shevchenko