[PATCH 0/2] MIPS: ralink: Fix missing prototypes warnings

[PATCH 0/2] MIPS: ralink: Fix missing prototypes warnings

[Vincent Legoll]

While building a current kernel for GnuBee PC1 hardware, I got some
warnings about missing function prototypes.

The following patches fix the warnings.
Is that the proper way to fix them ?

BTW, this is only compile-tested.

[PATCH 1/2] MIPS: ralink: Fix missing `plat_time_init` prototype

[Vincent Legoll]

Fix the following warning:

  CC      arch/mips/ralink/timer-gic.o
arch/mips/ralink/timer-gic.c:18:13: warning: no previous prototype for 'plat_time_init' [-Wmissing-prototypes]
   18 | void __init plat_time_init(void)
      |             ^~~~~~~~~~~~~~

Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
 arch/mips/ralink/timer-gic.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/mips/ralink/timer-gic.c b/arch/mips/ralink/timer-gic.c
index dcf2a44ac51e..926082655a78 100644
--- a/arch/mips/ralink/timer-gic.c
+++ b/arch/mips/ralink/timer-gic.c
@@ -11,6 +11,8 @@
 #include <linux/of_clk.h>
 #include <linux/clocksource.h>
 
+#include <asm/time.h>
+
 #include "common.h"
 
 void __init plat_time_init(void)
-- 
2.46.0

[PATCH 2/2] MIPS: ralink: Fix missing `get_c0_perfcount_int` prototype

[Vincent Legoll]

Fix the following warning:

  CC      arch/mips/ralink/irq-gic.o
arch/mips/ralink/irq-gic.c:15:5: warning: no previous prototype for 'get_c0_perfcount_int' [-Wmissing-prototypes]
   15 | int get_c0_perfcount_int(void)
      |     ^~~~~~~~~~~~~~~~~~~~

Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
 arch/mips/ralink/irq-gic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/ralink/irq-gic.c b/arch/mips/ralink/irq-gic.c
index 3bab51a5fb4c..8bc566ea00e5 100644
--- a/arch/mips/ralink/irq-gic.c
+++ b/arch/mips/ralink/irq-gic.c
@@ -10,6 +10,7 @@
 #include <linux/of.h>
 #include <linux/irqchip.h>
 #include <asm/mips-cps.h>
+#include <asm/time.h>
 
 int get_c0_perfcount_int(void)
 {
-- 
2.46.0

Re: [PATCH 1/2] MIPS: ralink: Fix missing `plat_time_init` prototype

[Thomas Bogendoerfer]

On Mon, Aug 12, 2024 at 03:17:42PM +0200, Vincent Legoll wrote:
> Fix the following warning:
> 
>   CC      arch/mips/ralink/timer-gic.o
> arch/mips/ralink/timer-gic.c:18:13: warning: no previous prototype for 'plat_time_init' [-Wmissing-prototypes]
>    18 | void __init plat_time_init(void)
>       |             ^~~~~~~~~~~~~~
> 
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
> ---
>  arch/mips/ralink/timer-gic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/ralink/timer-gic.c b/arch/mips/ralink/timer-gic.c
> index dcf2a44ac51e..926082655a78 100644
> --- a/arch/mips/ralink/timer-gic.c
> +++ b/arch/mips/ralink/timer-gic.c
> @@ -11,6 +11,8 @@
>  #include <linux/of_clk.h>
>  #include <linux/clocksource.h>
>  
> +#include <asm/time.h>
> +
>  #include "common.h"
>  
>  void __init plat_time_init(void)
> -- 
> 2.46.0

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH 2/2] MIPS: ralink: Fix missing `get_c0_perfcount_int` prototype

[Thomas Bogendoerfer]

On Mon, Aug 12, 2024 at 03:17:43PM +0200, Vincent Legoll wrote:
> Fix the following warning:
> 
>   CC      arch/mips/ralink/irq-gic.o
> arch/mips/ralink/irq-gic.c:15:5: warning: no previous prototype for 'get_c0_perfcount_int' [-Wmissing-prototypes]
>    15 | int get_c0_perfcount_int(void)
>       |     ^~~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
> ---
>  arch/mips/ralink/irq-gic.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/ralink/irq-gic.c b/arch/mips/ralink/irq-gic.c
> index 3bab51a5fb4c..8bc566ea00e5 100644
> --- a/arch/mips/ralink/irq-gic.c
> +++ b/arch/mips/ralink/irq-gic.c
> @@ -10,6 +10,7 @@
>  #include <linux/of.h>
>  #include <linux/irqchip.h>
>  #include <asm/mips-cps.h>
> +#include <asm/time.h>
>  
>  int get_c0_perfcount_int(void)
>  {
> -- 
> 2.46.0

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]