From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ferry Toth <fntoth@gmail.com>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Viresh Kumar <vireshk@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: dw: Select only supported masters for ACPI devices
Date: Fri, 20 Sep 2024 18:51:19 +0300 [thread overview]
Message-ID: <Zu2Z99pULL_m66Dm@smile.fi.intel.com> (raw)
In-Reply-To: <2627811.Lt9SDvczpP@ferry-quad>
On Fri, Sep 20, 2024 at 10:52:18AM +0200, Ferry Toth wrote:
> Op donderdag 19 september 2024 22:06:24 CEST schreef Andy Shevchenko:
> > On Thu, Sep 19, 2024 at 09:51:48PM +0300, Serge Semin wrote:
...
> > > Fix the problem by specifying a single master ID for both memory and
> > > peripheral devices on the ACPI-based platforms if there is only one master
> > > available on the controller. Thus the issue noticed for the iDMA32
> > > controllers will be eliminated and the ACPI-probed DW DMA controllers will
> > > be configured with the correct master ID by default.
> >
> > Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Seems this fixes the bug I have seen.
> > Ferry, can you confirm?
> I was testing something else and broke my setup :-(
> I’ll fix that and test this patch this weekend.
Thinking about this more I believe it's not the best what we can do.
Because this leaves a potential gap for the devices of more than one
master but in different order.
I'll send another patch after my testing.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-09-20 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 13:58 [PATCH] dmaengine: dw: Select only supported masters for ACPI devices Serge Semin
2024-09-19 15:14 ` Andy Shevchenko
2024-09-19 16:10 ` Serge Semin
2024-09-19 18:51 ` [PATCH v2] " Serge Semin
2024-09-19 20:06 ` Andy Shevchenko
2024-09-20 8:52 ` Ferry Toth
2024-09-20 15:51 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zu2Z99pULL_m66Dm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=fntoth@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox