The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH v2] sched/eevdf: Fix wakeup-preempt by checking cfs_rq->nr_running
@ 2024-09-25  8:54 Chen Yu
  2024-09-27  1:54 ` Honglei Wang
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Chen Yu @ 2024-09-25  8:54 UTC (permalink / raw)
  To: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot
  Cc: Dietmar Eggemann, Valentin Schneider, Chunxin Zang, linux-kernel,
	Chen Yu, Chen Yu, kernel test robot, K Prateek Nayak

Commit 85e511df3cec ("sched/eevdf: Allow shorter slices to wakeup-preempt")
introduced a mechanism that a wakee with shorter slice could preempt
the current running task. It also lower the bar for the current task
to be preempted, by checking the rq->nr_running instead of cfs_rq->nr_running
when the current task has ran out of time slice. But there is a scenario
that is problematic. Say, if there is 1 cfs task and 1 rt task, before
85e511df3cec, update_deadline() will not trigger a reschedule, and after
85e511df3cec, since rq->nr_running is 2 and resched is true, a resched_curr()
would happen.

Some workloads (like the hackbench reported by lkp) do not like
over-scheduling. We can see that the preemption rate has been
increased by 2.2%:

1.654e+08            +2.2%   1.69e+08        hackbench.time.involuntary_context_switches

Restore its previous check criterion.

Fixes: 85e511df3cec ("sched/eevdf: Allow shorter slices to wakeup-preempt")
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202409231416.9403c2e9-oliver.sang@intel.com
Suggested-by: K Prateek Nayak <kprateek.nayak@amd.com>
Tested-by: K Prateek Nayak <kprateek.nayak@amd.com>
Signed-off-by: Chen Yu <yu.c.chen@intel.com>
---
v1->v2:
    Check cfs_rq->nr_running instead of rq->nr_running(K Prateek Nayak)
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 225b31aaee55..53a351b18740 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1247,7 +1247,7 @@ static void update_curr(struct cfs_rq *cfs_rq)
 
 	account_cfs_rq_runtime(cfs_rq, delta_exec);
 
-	if (rq->nr_running == 1)
+	if (cfs_rq->nr_running == 1)
 		return;
 
 	if (resched || did_preempt_short(cfs_rq, curr)) {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-10-04 10:16 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-25  8:54 [PATCH v2] sched/eevdf: Fix wakeup-preempt by checking cfs_rq->nr_running Chen Yu
2024-09-27  1:54 ` Honglei Wang
2024-09-27  6:56   ` Chen Yu
2024-09-27 13:38     ` Honglei Wang
2024-09-28  6:28       ` Chen Yu
2024-09-29 13:51         ` Oliver Sang
2024-09-30  2:04           ` Honglei Wang
2024-09-30  2:22             ` Chen Yu
2024-09-30  6:11               ` Honglei Wang
2024-09-30  7:50 ` Peter Zijlstra
2024-09-30 11:01   ` Chen Yu
2024-10-04 10:16 ` [tip: sched/urgent] " tip-bot2 for Chen Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox