* Re: [PATCH] drm/xe/xe2lpg: Add WA 15016589081
2024-09-30 12:06 [PATCH] drm/xe/xe2lpg: Add WA 15016589081 Aradhya Bhatia
@ 2024-09-30 12:33 ` Dr. David Alan Gilbert
2024-09-30 13:18 ` Upadhyay, Tejas
2024-09-30 13:21 ` Upadhyay, Tejas
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2024-09-30 12:33 UTC (permalink / raw)
To: Aradhya Bhatia
Cc: Rodrigo Vivi, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Intel XE List, DRI Devel List,
Linux Kernel List, Jani Nikula, Matt Roper, Tejas Upadhyay,
Himal Prasad Ghimiray, Gustavo Sousa
* Aradhya Bhatia (aradhya.bhatia@intel.com) wrote:
> Add workaround (wa) 15016589081 which applies to Xe2_v3_LPG_MD.
It would be great in this type of patch if you could
briefly say what symptom it fixes; Some people might not know what
WA 15016589081 does.
Dave
> Xe2_v3_LPG_MD is a Lunar Lake platform with GFX version: 20.04.
> This wa is type: permanent, and hence is applicable on all steppings.
>
> Signed-off-by: Aradhya Bhatia <aradhya.bhatia@intel.com>
> ---
> drivers/gpu/drm/xe/xe_wa.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
> index 22c148b1e996..2f9cde4b7d45 100644
> --- a/drivers/gpu/drm/xe/xe_wa.c
> +++ b/drivers/gpu/drm/xe/xe_wa.c
> @@ -710,6 +710,10 @@ static const struct xe_rtp_entry_sr lrc_was[] = {
> DIS_PARTIAL_AUTOSTRIP |
> DIS_AUTOSTRIP))
> },
> + { XE_RTP_NAME("15016589081"),
> + XE_RTP_RULES(GRAPHICS_VERSION(2004), ENGINE_CLASS(RENDER)),
> + XE_RTP_ACTIONS(SET(CHICKEN_RASTER_1, DIS_CLIP_NEGATIVE_BOUNDING_BOX))
> + },
>
> /* Xe2_HPG */
> { XE_RTP_NAME("15010599737"),
>
> base-commit: 0c8650b09a365f4a31fca1d1d1e9d99c56071128
> --
> 2.34.1
>
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] drm/xe/xe2lpg: Add WA 15016589081
2024-09-30 12:06 [PATCH] drm/xe/xe2lpg: Add WA 15016589081 Aradhya Bhatia
2024-09-30 12:33 ` Dr. David Alan Gilbert
@ 2024-09-30 13:18 ` Upadhyay, Tejas
2024-09-30 13:21 ` Upadhyay, Tejas
2 siblings, 0 replies; 4+ messages in thread
From: Upadhyay, Tejas @ 2024-09-30 13:18 UTC (permalink / raw)
To: Bhatia, Aradhya, Vivi, Rodrigo, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: Intel XE List, DRI Devel List, Linux Kernel List, Jani Nikula,
Roper, Matthew D, Ghimiray, Himal Prasad, Sousa, Gustavo
> -----Original Message-----
> From: Bhatia, Aradhya <aradhya.bhatia@intel.com>
> Sent: Monday, September 30, 2024 5:36 PM
> To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com>; Maxime Ripard
> <mripard@kernel.org>; Thomas Zimmermann <tzimmermann@suse.de>;
> David Airlie <airlied@gmail.com>; Simona Vetter <simona@ffwll.ch>
> Cc: Intel XE List <intel-xe@lists.freedesktop.org>; DRI Devel List <dri-
> devel@lists.freedesktop.org>; Linux Kernel List <linux-
> kernel@vger.kernel.org>; Jani Nikula <jani.nikula@linux.intel.com>; Roper,
> Matthew D <matthew.d.roper@intel.com>; Upadhyay, Tejas
> <tejas.upadhyay@intel.com>; Ghimiray, Himal Prasad
> <himal.prasad.ghimiray@intel.com>; Sousa, Gustavo
> <gustavo.sousa@intel.com>; Bhatia, Aradhya <aradhya.bhatia@intel.com>
> Subject: [PATCH] drm/xe/xe2lpg: Add WA 15016589081
We can say, extend WA 15016589081 to xe2_lpg
>
> Add workaround (wa) 15016589081 which applies to Xe2_v3_LPG_MD.
>
> Xe2_v3_LPG_MD is a Lunar Lake platform with GFX version: 20.04.
> This wa is type: permanent, and hence is applicable on all steppings.
>
> Signed-off-by: Aradhya Bhatia <aradhya.bhatia@intel.com>
> ---
> drivers/gpu/drm/xe/xe_wa.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c index
> 22c148b1e996..2f9cde4b7d45 100644
> --- a/drivers/gpu/drm/xe/xe_wa.c
> +++ b/drivers/gpu/drm/xe/xe_wa.c
> @@ -710,6 +710,10 @@ static const struct xe_rtp_entry_sr lrc_was[] = {
> DIS_PARTIAL_AUTOSTRIP |
> DIS_AUTOSTRIP))
> },
> + { XE_RTP_NAME("15016589081"),
> + XE_RTP_RULES(GRAPHICS_VERSION(2004),
> ENGINE_CLASS(RENDER)),
> + XE_RTP_ACTIONS(SET(CHICKEN_RASTER_1,
> DIS_CLIP_NEGATIVE_BOUNDING_BOX))
> + },
Change LGTM, If CI results are ok, you can add,
Reviewed-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
>
> /* Xe2_HPG */
> { XE_RTP_NAME("15010599737"),
>
> base-commit: 0c8650b09a365f4a31fca1d1d1e9d99c56071128
> --
> 2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] drm/xe/xe2lpg: Add WA 15016589081
2024-09-30 12:06 [PATCH] drm/xe/xe2lpg: Add WA 15016589081 Aradhya Bhatia
2024-09-30 12:33 ` Dr. David Alan Gilbert
2024-09-30 13:18 ` Upadhyay, Tejas
@ 2024-09-30 13:21 ` Upadhyay, Tejas
2 siblings, 0 replies; 4+ messages in thread
From: Upadhyay, Tejas @ 2024-09-30 13:21 UTC (permalink / raw)
To: Bhatia, Aradhya, Vivi, Rodrigo, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: Intel XE List, DRI Devel List, Linux Kernel List, Jani Nikula,
Roper, Matthew D, Ghimiray, Himal Prasad, Sousa, Gustavo
> -----Original Message-----
> From: Bhatia, Aradhya <aradhya.bhatia@intel.com>
> Sent: Monday, September 30, 2024 5:36 PM
> To: Vivi, Rodrigo <rodrigo.vivi@intel.com>; Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com>; Maxime Ripard
> <mripard@kernel.org>; Thomas Zimmermann <tzimmermann@suse.de>;
> David Airlie <airlied@gmail.com>; Simona Vetter <simona@ffwll.ch>
> Cc: Intel XE List <intel-xe@lists.freedesktop.org>; DRI Devel List <dri-
> devel@lists.freedesktop.org>; Linux Kernel List <linux-
> kernel@vger.kernel.org>; Jani Nikula <jani.nikula@linux.intel.com>; Roper,
> Matthew D <matthew.d.roper@intel.com>; Upadhyay, Tejas
> <tejas.upadhyay@intel.com>; Ghimiray, Himal Prasad
> <himal.prasad.ghimiray@intel.com>; Sousa, Gustavo
> <gustavo.sousa@intel.com>; Bhatia, Aradhya <aradhya.bhatia@intel.com>
> Subject: [PATCH] drm/xe/xe2lpg: Add WA 15016589081
Also please mention "drm/xe/xe2lpg: Extend Wa_15016589081 for xe2lpg"
Wa_15016589081 is for making uniform subject across WAs.
Tejas
>
> Add workaround (wa) 15016589081 which applies to Xe2_v3_LPG_MD.
>
> Xe2_v3_LPG_MD is a Lunar Lake platform with GFX version: 20.04.
> This wa is type: permanent, and hence is applicable on all steppings.
>
> Signed-off-by: Aradhya Bhatia <aradhya.bhatia@intel.com>
> ---
> drivers/gpu/drm/xe/xe_wa.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c index
> 22c148b1e996..2f9cde4b7d45 100644
> --- a/drivers/gpu/drm/xe/xe_wa.c
> +++ b/drivers/gpu/drm/xe/xe_wa.c
> @@ -710,6 +710,10 @@ static const struct xe_rtp_entry_sr lrc_was[] = {
> DIS_PARTIAL_AUTOSTRIP |
> DIS_AUTOSTRIP))
> },
> + { XE_RTP_NAME("15016589081"),
> + XE_RTP_RULES(GRAPHICS_VERSION(2004),
> ENGINE_CLASS(RENDER)),
> + XE_RTP_ACTIONS(SET(CHICKEN_RASTER_1,
> DIS_CLIP_NEGATIVE_BOUNDING_BOX))
> + },
>
> /* Xe2_HPG */
> { XE_RTP_NAME("15010599737"),
>
> base-commit: 0c8650b09a365f4a31fca1d1d1e9d99c56071128
> --
> 2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread