* [PATCH] elevator: Remove argument from elevator_find_get
@ 2024-10-11 15:56 Breno Leitao
2024-10-11 17:11 ` Jens Axboe
2024-10-14 5:56 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Breno Leitao @ 2024-10-11 15:56 UTC (permalink / raw)
To: hch, Jens Axboe, Bart Van Assche, Martin K. Petersen,
Damien Le Moal, Hannes Reinecke
Cc: kernel-team, open list:BLOCK LAYER, open list
Commit e4eb37cc0f3ed ("block: Remove elevator required features")
removed the usage of `struct request_queue` from elevator_find_get(),
but didn't removed the argument.
Remove the "struct request_queue *q" argument from elevator_find_get()
given it is useless.
Fixes: e4eb37cc0f3e ("block: Remove elevator required features")
Signed-off-by: Breno Leitao <leitao@debian.org>
---
block/elevator.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/block/elevator.c b/block/elevator.c
index 4122026b11f1..565807f0b1c7 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -106,8 +106,7 @@ static struct elevator_type *__elevator_find(const char *name)
return NULL;
}
-static struct elevator_type *elevator_find_get(struct request_queue *q,
- const char *name)
+static struct elevator_type *elevator_find_get(const char *name)
{
struct elevator_type *e;
@@ -569,7 +568,7 @@ static struct elevator_type *elevator_get_default(struct request_queue *q)
!blk_mq_is_shared_tags(q->tag_set->flags))
return NULL;
- return elevator_find_get(q, "mq-deadline");
+ return elevator_find_get("mq-deadline");
}
/*
@@ -697,7 +696,7 @@ static int elevator_change(struct request_queue *q, const char *elevator_name)
if (q->elevator && elevator_match(q->elevator->type, elevator_name))
return 0;
- e = elevator_find_get(q, elevator_name);
+ e = elevator_find_get(elevator_name);
if (!e)
return -EINVAL;
ret = elevator_switch(q, e);
--
2.43.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] elevator: Remove argument from elevator_find_get
2024-10-11 15:56 [PATCH] elevator: Remove argument from elevator_find_get Breno Leitao
@ 2024-10-11 17:11 ` Jens Axboe
2024-10-14 5:56 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2024-10-11 17:11 UTC (permalink / raw)
To: hch, Bart Van Assche, Martin K. Petersen, Damien Le Moal,
Hannes Reinecke, Breno Leitao
Cc: kernel-team, linux-block, linux-kernel
On Fri, 11 Oct 2024 08:56:15 -0700, Breno Leitao wrote:
> Commit e4eb37cc0f3ed ("block: Remove elevator required features")
> removed the usage of `struct request_queue` from elevator_find_get(),
> but didn't removed the argument.
>
> Remove the "struct request_queue *q" argument from elevator_find_get()
> given it is useless.
>
> [...]
Applied, thanks!
[1/1] elevator: Remove argument from elevator_find_get
commit: ee7ff15bf507d4cf9a2b11b00690dfe6046ad325
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] elevator: Remove argument from elevator_find_get
2024-10-11 15:56 [PATCH] elevator: Remove argument from elevator_find_get Breno Leitao
2024-10-11 17:11 ` Jens Axboe
@ 2024-10-14 5:56 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2024-10-14 5:56 UTC (permalink / raw)
To: Breno Leitao
Cc: hch, Jens Axboe, Bart Van Assche, Martin K. Petersen,
Damien Le Moal, Hannes Reinecke, kernel-team,
open list:BLOCK LAYER, open list
On Fri, Oct 11, 2024 at 08:56:15AM -0700, Breno Leitao wrote:
> Commit e4eb37cc0f3ed ("block: Remove elevator required features")
> removed the usage of `struct request_queue` from elevator_find_get(),
> but didn't removed the argument.
>
> Remove the "struct request_queue *q" argument from elevator_find_get()
> given it is useless.
>
> Fixes: e4eb37cc0f3e ("block: Remove elevator required features")
> Signed-off-by: Breno Leitao <leitao@debian.org>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-14 5:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-11 15:56 [PATCH] elevator: Remove argument from elevator_find_get Breno Leitao
2024-10-11 17:11 ` Jens Axboe
2024-10-14 5:56 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox