[PATCH v2 0/2] mfd: intel_soc_pmic_crc: Add support for non ACPI instantiated i2c_client

[PATCH v2 0/2] mfd: intel_soc_pmic_crc: Add support for non ACPI instantiated i2c_client

[Hans de Goede]

Hi All,

Here is v2 of my series to add support for non ACPI instantiated
i2c_client-s to intel_soc_pmic_crc.

Changes in v2:
- Consistently use the filename as driver name for all intel_soc_pmic_*
  drivers
- Use "intel_soc_pmic_crc" as i2c_device_id.name

Regards,

Hans


Hans de Goede (2):
  mfd: intel_soc_pmic_*: Consistently use filename as driver name
  mfd: intel_soc_pmic_crc: Add support for non ACPI instantiated
    i2c_client

 drivers/mfd/intel_soc_pmic_bxtwc.c | 2 +-
 drivers/mfd/intel_soc_pmic_chtwc.c | 2 +-
 drivers/mfd/intel_soc_pmic_crc.c   | 9 ++++++++-
 3 files changed, 10 insertions(+), 3 deletions(-)

-- 
2.47.0

[PATCH v2 1/2] mfd: intel_soc_pmic_*: Consistently use filename as driver name

[Hans de Goede]

Currently the intel_soc_pmic_bxtwc, intel_soc_pmic_chtwc and
intel_soc_pmic_crc PMIC drivers use more or less free form strings
for their driver name.

Where as intel_soc_pmic_chtdc_ti and intel_soc_pmic_mrfld use the driver's
filename as driver name.

Update the 3 others to also use the driver's filename to make the naming
consistent.

Suggested-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/mfd/intel_soc_pmic_bxtwc.c | 2 +-
 drivers/mfd/intel_soc_pmic_chtwc.c | 2 +-
 drivers/mfd/intel_soc_pmic_crc.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/intel_soc_pmic_bxtwc.c b/drivers/mfd/intel_soc_pmic_bxtwc.c
index ccd76800d8e4..db98675f7ffa 100644
--- a/drivers/mfd/intel_soc_pmic_bxtwc.c
+++ b/drivers/mfd/intel_soc_pmic_bxtwc.c
@@ -571,7 +571,7 @@ static struct platform_driver bxtwc_driver = {
 	.probe = bxtwc_probe,
 	.shutdown = bxtwc_shutdown,
 	.driver	= {
-		.name	= "BXTWC PMIC",
+		.name	= "intel_soc_pmic_bxtwc",
 		.pm     = pm_sleep_ptr(&bxtwc_pm_ops),
 		.acpi_match_table = bxtwc_acpi_ids,
 		.dev_groups = bxtwc_groups,
diff --git a/drivers/mfd/intel_soc_pmic_chtwc.c b/drivers/mfd/intel_soc_pmic_chtwc.c
index 2a83f540d4c9..aa71a7d83fcd 100644
--- a/drivers/mfd/intel_soc_pmic_chtwc.c
+++ b/drivers/mfd/intel_soc_pmic_chtwc.c
@@ -267,7 +267,7 @@ static const struct acpi_device_id cht_wc_acpi_ids[] = {
 
 static struct i2c_driver cht_wc_driver = {
 	.driver	= {
-		.name	= "CHT Whiskey Cove PMIC",
+		.name	= "intel_soc_pmic_chtwc",
 		.pm     = pm_sleep_ptr(&cht_wc_pm_ops),
 		.acpi_match_table = cht_wc_acpi_ids,
 	},
diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
index 876d017f74fe..663a9e93ce87 100644
--- a/drivers/mfd/intel_soc_pmic_crc.c
+++ b/drivers/mfd/intel_soc_pmic_crc.c
@@ -261,7 +261,7 @@ MODULE_DEVICE_TABLE(acpi, crystal_cove_acpi_match);
 
 static struct i2c_driver crystal_cove_i2c_driver = {
 	.driver = {
-		.name = "crystal_cove_i2c",
+		.name = "intel_soc_pmic_crc",
 		.pm = pm_sleep_ptr(&crystal_cove_pm_ops),
 		.acpi_match_table = crystal_cove_acpi_match,
 	},
-- 
2.47.0

[PATCH v2 2/2] mfd: intel_soc_pmic_crc: Add support for non ACPI instantiated i2c_client

[Hans de Goede]

On some x86 Bay Trail tablets which shipped with Android as factory OS,
the DSDT is so broken that the PMIC needs to be manually instantiated by
the special x86-android-tablets.ko "fixup" driver for cases like this.

Add an i2c_device_id table so that the driver can match on manually
instantiated i2c_client-s (which lack an ACPI fwnode to match on).

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Changes in v2:
- Use "intel_soc_pmic_crc" as i2c_device_id.name
---
 drivers/mfd/intel_soc_pmic_crc.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
index 663a9e93ce87..879fbf5cd162 100644
--- a/drivers/mfd/intel_soc_pmic_crc.c
+++ b/drivers/mfd/intel_soc_pmic_crc.c
@@ -259,12 +259,19 @@ static const struct acpi_device_id crystal_cove_acpi_match[] = {
 };
 MODULE_DEVICE_TABLE(acpi, crystal_cove_acpi_match);
 
+static const struct i2c_device_id crystal_cove_i2c_match[] = {
+	{ "intel_soc_pmic_crc" },
+	{ }
+};
+MODULE_DEVICE_TABLE(i2c, crystal_cove_i2c_match);
+
 static struct i2c_driver crystal_cove_i2c_driver = {
 	.driver = {
 		.name = "intel_soc_pmic_crc",
 		.pm = pm_sleep_ptr(&crystal_cove_pm_ops),
 		.acpi_match_table = crystal_cove_acpi_match,
 	},
+	.id_table = crystal_cove_i2c_match,
 	.probe = crystal_cove_i2c_probe,
 	.remove = crystal_cove_i2c_remove,
 	.shutdown = crystal_cove_shutdown,
-- 
2.47.0

Re: [PATCH v2 0/2] mfd: intel_soc_pmic_crc: Add support for non ACPI instantiated i2c_client

[Andy Shevchenko]

On Mon, Nov 04, 2024 at 04:06:53PM +0100, Hans de Goede wrote:
> Hi All,
> 
> Here is v2 of my series to add support for non ACPI instantiated
> i2c_client-s to intel_soc_pmic_crc.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/2] mfd: intel_soc_pmic_crc: Add support for non ACPI instantiated i2c_client

[Lee Jones]

On Mon, 04 Nov 2024 16:06:53 +0100, Hans de Goede wrote:
> Here is v2 of my series to add support for non ACPI instantiated
> i2c_client-s to intel_soc_pmic_crc.
> 
> Changes in v2:
> - Consistently use the filename as driver name for all intel_soc_pmic_*
>   drivers
> - Use "intel_soc_pmic_crc" as i2c_device_id.name
> 
> [...]

Applied, thanks!

[1/2] mfd: intel_soc_pmic_*: Consistently use filename as driver name
      commit: c3768c474830fab0fa3063e72dd005eb6cef0618
[2/2] mfd: intel_soc_pmic_crc: Add support for non ACPI instantiated i2c_client
      commit: bd302f82be1e10a1395d58d405e0e8af049d1cc3

--
Lee Jones [李琼斯]

Re: [PATCH v2 1/2] mfd: intel_soc_pmic_*: Consistently use filename as driver name

[Andy Shevchenko]

On Mon, Nov 04, 2024 at 04:06:54PM +0100, Hans de Goede wrote:
> Currently the intel_soc_pmic_bxtwc, intel_soc_pmic_chtwc and
> intel_soc_pmic_crc PMIC drivers use more or less free form strings
> for their driver name.
> 
> Where as intel_soc_pmic_chtdc_ti and intel_soc_pmic_mrfld use the driver's
> filename as driver name.
> 
> Update the 3 others to also use the driver's filename to make the naming
> consistent.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko