public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>, <hch@lst.de>,
	<m.szyprowski@samsung.com>, <robin.murphy@arm.com>,
	<tony@atomide.com>
Cc: <vdumpa@nvidia.com>, <iommu@lists.linux-foundation.org>,
	<linux-kernel@vger.kernel.org>, <tomi.valkeinen@ti.com>,
	<laurent.pinchart@ideasonboard.com>, <sre@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-omap@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	linux-tegra <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] Revert "dma-contiguous: do not allocate a single page from CMA area"
Date: Wed, 27 Feb 2019 14:04:25 +0000	[thread overview]
Message-ID: <a3ebd508-04a3-6ad2-5cd4-332282f21a8a@nvidia.com> (raw)
In-Reply-To: <20190226202327.5349-1-nicoleotsuka@gmail.com>


On 26/02/2019 20:23, Nicolin Chen wrote:
> This reverts commit d222e42e88168fd67e6d131984b86477af1fc256.
> 
> The original change breaks omap dss:
>     omapdss_dispc 58001000.dispc:
>         dispc_errata_i734_wa_init: dma_alloc_writecombine failed
> 
> Let's revert it first and then find a safer solution instead.
> 
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
> Tony,
> 	
> Would you please test and verify? Thanks!

This also fixes various memory allocation failures we have seen on
32-bit Tegra as well.

Tested-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic

      parent reply	other threads:[~2019-02-27 14:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26 20:23 [PATCH] Revert "dma-contiguous: do not allocate a single page from CMA area" Nicolin Chen
2019-02-26 23:35 ` Robin Murphy
2019-02-27  0:42   ` Tony Lindgren
2019-02-27  0:48   ` Nicolin Chen
2019-02-27  8:46 ` Krzysztof Kozlowski
2019-02-27 14:04 ` Jon Hunter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3ebd508-04a3-6ad2-5cd4-332282f21a8a@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=robin.murphy@arm.com \
    --cc=sre@kernel.org \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    --cc=vdumpa@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox