From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@ziepe.ca>
Cc: "Jiang, Dave" <dave.jiang@intel.com>,
Vinod Koul <vkoul@kernel.org>, Fenghua Yu <fenghuay@nvidia.com>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Zhou Wang <wangzhou1@hisilicon.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 08/12] iommufd/selftest: Put iopf enablement in domain attach path
Date: Wed, 26 Feb 2025 12:06:18 +0800 [thread overview]
Message-ID: <a4d650cf-c8e4-4590-ab6f-f464a17125d1@linux.intel.com> (raw)
In-Reply-To: <BN9PR11MB5276852398C05D067FEFB2DF8CC32@BN9PR11MB5276.namprd11.prod.outlook.com>
On 2/25/25 16:16, Tian, Kevin wrote:
>> + ret = mock_dev_enable_iopf(dev, domain);
>> + if (ret)
>> + return ret;
>> +
>> + mock_dev_disable_iopf(dev, mdev->domain);
> You could use the same trick to simplify iopf_for_domain_replace()
> in patch7?
Yes, simplify it like this,
static inline int iopf_for_domain_replace(struct iommu_domain *new,
struct iommu_domain *old,
struct device *dev)
{
int ret;
ret = iopf_for_domain_set(new, dev);
if (ret)
return ret;
iopf_for_domain_remove(old, dev);
return 0;
}
Thanks,
baolu
next prev parent reply other threads:[~2025-02-26 4:09 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 5:16 [PATCH v2 00/12] iommu: Remove IOMMU_DEV_FEAT_SVA/_IOPF Lu Baolu
2025-02-24 5:16 ` [PATCH v2 01/12] iommu/arm-smmu-v3: Put iopf enablement in the domain attach path Lu Baolu
2025-02-24 5:16 ` [PATCH v2 02/12] iommu/vt-d: Check if SVA is supported when attaching the SVA domain Lu Baolu
2025-02-25 7:23 ` Tian, Kevin
2025-03-04 7:44 ` Yi Liu
2025-02-24 5:16 ` [PATCH v2 03/12] iommu: Remove IOMMU_DEV_FEAT_SVA Lu Baolu
2025-02-25 7:24 ` Tian, Kevin
2025-03-04 7:50 ` Yi Liu
2025-02-24 5:16 ` [PATCH v2 04/12] iommu/vt-d: Move scalable mode ATS enablement to probe path Lu Baolu
2025-02-25 7:28 ` Tian, Kevin
2025-02-26 2:21 ` Baolu Lu
2025-03-04 7:55 ` Yi Liu
2025-02-24 5:16 ` [PATCH v2 05/12] iommu/vt-d: Move PRI enablement in " Lu Baolu
2025-02-25 7:37 ` Tian, Kevin
2025-02-26 3:53 ` Baolu Lu
2025-02-24 5:16 ` [PATCH v2 06/12] iommu/vt-d: Cleanup intel_context_flush_present() Lu Baolu
2025-02-25 7:43 ` Tian, Kevin
2025-02-26 3:57 ` Baolu Lu
2025-02-26 5:17 ` Tian, Kevin
2025-03-04 8:43 ` Yi Liu
2025-03-05 2:21 ` Baolu Lu
2025-03-05 3:34 ` Yi Liu
2025-03-05 5:36 ` Baolu Lu
2025-02-24 5:16 ` [PATCH v2 07/12] iommu/vt-d: Put iopf enablement in domain attach path Lu Baolu
2025-02-25 8:02 ` Tian, Kevin
2025-02-24 5:16 ` [PATCH v2 08/12] iommufd/selftest: " Lu Baolu
2025-02-25 8:16 ` Tian, Kevin
2025-02-26 4:06 ` Baolu Lu [this message]
2025-02-24 5:16 ` [PATCH v2 09/12] dmaengine: idxd: Remove unnecessary IOMMU_DEV_FEAT_IOPF Lu Baolu
2025-02-25 8:16 ` Tian, Kevin
2025-02-24 5:16 ` [PATCH v2 10/12] uacce: " Lu Baolu
2025-02-24 10:00 ` Zhangfei Gao
2025-02-25 8:17 ` Tian, Kevin
2025-02-24 5:16 ` [PATCH v2 11/12] iommufd: " Lu Baolu
2025-02-25 8:18 ` Tian, Kevin
2025-02-24 5:16 ` [PATCH v2 12/12] iommu: Remove iommu_dev_enable/disable_feature() Lu Baolu
2025-02-25 8:18 ` Tian, Kevin
2025-02-24 9:58 ` [PATCH v2 00/12] iommu: Remove IOMMU_DEV_FEAT_SVA/_IOPF Zhangfei Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4d650cf-c8e4-4590-ab6f-f464a17125d1@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=fenghuay@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=vkoul@kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=will@kernel.org \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox