From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, me@kylehuey.com,
Linux-kernel@vger.kernel.org, vincent.weaver@maine.edu,
will.deacon@arm.com, eranian@google.com, namhyung@kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v1 0/2] perf: Drop leaked kernel samples
Date: Fri, 15 Jun 2018 16:24:49 +0800 [thread overview]
Message-ID: <a8ba2079-b880-a145-a4e0-754d58ccdc8f@linux.intel.com> (raw)
In-Reply-To: <20180615081223.GB2458@hirez.programming.kicks-ass.net>
On 6/15/2018 4:12 PM, Peter Zijlstra wrote:
> On Fri, Jun 15, 2018 at 04:01:45PM +0800, Jin, Yao wrote:
>
>> Bring more overhead to kernel if we zero the bits considering the number of
>> leaked samples may be not too small?
>
> Keeping the samples at least allows you to know how many samples
> happened and such things.
>
Yeah, agree, but a little bit overhead ...
>> And the skid information may be interesting (see example of hitting on
>> page_fault in previous mail). If we zero it, we will not know.
>
> If you throw them out the window you also don't know, do you?
>
Yes, default I can't know that window. I have to use sysctl to enable.
Thanks
Jin Yao
next prev parent reply other threads:[~2018-06-15 8:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 10:03 [PATCH v1 0/2] perf: Drop leaked kernel samples Jin Yao
2018-06-15 3:35 ` Kyle Huey
2018-06-15 5:11 ` Jin, Yao
2018-06-15 17:16 ` Kyle Huey
2018-06-15 17:34 ` Robert O'Callahan
2018-06-16 0:50 ` Jin, Yao
2018-06-16 0:56 ` Kyle Huey
2018-06-16 1:18 ` Jin, Yao
2018-06-15 7:45 ` Peter Zijlstra
2018-06-15 8:01 ` Jin, Yao
2018-06-15 8:12 ` Peter Zijlstra
2018-06-15 8:24 ` Jin, Yao [this message]
2018-06-15 16:54 ` Stephane Eranian
2018-06-15 10:03 ` [PATCH v1 1/2] perf/core: Use sysctl to turn on/off dropping " Jin Yao
2018-06-15 5:59 ` Stephane Eranian
2018-06-15 7:15 ` Jin, Yao
2018-06-19 16:50 ` Stephane Eranian
2018-06-15 6:02 ` Stephane Eranian
2018-06-15 8:16 ` Peter Zijlstra
2018-06-15 13:31 ` Liang, Kan
2018-06-18 10:41 ` Peter Zijlstra
2018-06-15 11:36 ` Mark Rutland
2018-06-16 1:27 ` Linus Torvalds
2018-06-18 10:51 ` Peter Zijlstra
2018-06-18 6:55 ` Jin, Yao
2018-06-18 10:45 ` Peter Zijlstra
2018-06-19 1:39 ` Jin, Yao
2018-06-19 6:01 ` Mark Rutland
2018-06-15 10:03 ` [PATCH v1 2/2] perf Documentation: Introduce the sysctl perf_allow_sample_leakage Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8ba2079-b880-a145-a4e0-754d58ccdc8f@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=me@kylehuey.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.weaver@maine.edu \
--cc=will.deacon@arm.com \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox