From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ally Heev <allyheev@gmail.com>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused variable in d3.c
Date: Sat, 22 Nov 2025 15:18:20 +0100 [thread overview]
Message-ID: <a9e12ace-dc0e-4bac-9775-72cd7d477169@kernel.org> (raw)
In-Reply-To: <20251121-aheev-remove-unused-var-old-keys-v1-1-6c2565c77ef7@gmail.com>
On 21/11/2025 15:27, Ally Heev wrote:
> remove unused variable `old_keys`
>
> Signed-off-by: Ally Heev <allyheev@gmail.com>
> ---
> drivers/net/wireless/intel/iwlwifi/mld/d3.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mld/d3.c b/drivers/net/wireless/intel/iwlwifi/mld/d3.c
> index 1d4282a21f09e0f90a52dc02c8287ecc0e0fafe1..fefb4f532a1f9fbb1a4a5cbd2ade817d5c1adb58 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mld/d3.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mld/d3.c
> @@ -996,8 +996,6 @@ static void iwl_mld_mlo_rekey(struct iwl_mld *mld,
> struct iwl_mld_wowlan_status *wowlan_status,
> struct ieee80211_vif *vif)
> {
> - struct iwl_mld_old_mlo_keys *old_keys __free(kfree) = NULL;
> -
> IWL_DEBUG_WOWLAN(mld, "Num of MLO Keys: %d\n", wowlan_status->num_mlo_keys);
>
> if (!wowlan_status->num_mlo_keys)
>
> ---
> base-commit: 4427259cc7f7571a157fbc9b5011e1ef6fe0a4a8
> change-id: 20251111-aheev-remove-unused-var-old-keys-104ffca9bf62
>
> Best regards,
> -----BEGIN PGP SIGNATURE-----
>
> iHUEABYKAB0WIQQBFRpOLrIakF7DYvaWPaLUP9d7HAUCaRLyowAKCRCWPaLUP9d7
> HLG9AQDZmggT93tMLv32pq5myG3e83t12KWON9efOBg//lH4vgD+Ppw3KoTpdYtJ
> 20VDaWuqUVj9KLqjx9hblfEiB7s9gQw=
> =A6F+
> -----END PGP SIGNATURE-----
You should switch to patatt instead, not signing emails. We don't use
that, I think at all, unlike patatt which is being actively checked by
toolkit (b4).
Anyway, not a problem, just noise, so:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-22 14:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 14:27 [PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused variable in d3.c Ally Heev
2025-11-22 14:18 ` Krzysztof Kozlowski [this message]
2025-11-24 15:38 ` Konstantin Ryabitsev
2025-11-24 15:58 ` ally heev
2025-11-24 16:28 ` Konstantin Ryabitsev
2025-11-25 7:20 ` ally heev
2025-11-25 13:54 ` Konstantin Ryabitsev
2025-11-25 16:00 ` ally heev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9e12ace-dc0e-4bac-9775-72cd7d477169@kernel.org \
--to=krzk@kernel.org \
--cc=allyheev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox