From: ally heev <allyheev@gmail.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused variable in d3.c
Date: Tue, 25 Nov 2025 21:30:24 +0530 [thread overview]
Message-ID: <e5419ba84c64e9146652864072b1941ef310de4f.camel@gmail.com> (raw)
In-Reply-To: <20251125-hot-seagull-of-trust-cc4bbe@lemur>
On Tue, 2025-11-25 at 08:54 -0500, Konstantin Ryabitsev wrote:
> On Tue, Nov 25, 2025 at 12:50:44PM +0530, ally heev wrote:
> > > > Yes, I use b4 for my patches. I work on other open source projects
> > > > which use Github. So, my global git config commit autosign is set to
> >
> > typo: `tag autosign`
> >
> > > > `true`, hence you have seen PGP signatures.
> > >
> > > Interesting! I've not seen this cause PGP signatures to be added to "git show"
> > > output before. I've tried to replicate it locally, but even if I have a signed
> > > git commit, I can't make the "gpgsig" header to show up in the output of "git
> > > show --format=email" (which is what b4 uses). Do you have some local git
> > > configuration changes that make "gpgsig" fields show up in the output of "git
> > > show"?
> > >
> > > -K
> >
> > I think b4 uses tags for patch series. I have checked old
> > patches(before disabling autosign) and found that signature is only
> > added on first(cover-letter) of the patch series
>
> Oh! Interesting, so this happened on resend? I'll test it out, thanks!
I didn't get it. Signature was added to every cover-letter of patch
series before I disabled `tag autosign`
>
> -K
prev parent reply other threads:[~2025-11-25 16:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 14:27 [PATCH RESEND iwlwifi-next] wifi: iwlwifi: mld: remove unused variable in d3.c Ally Heev
2025-11-22 14:18 ` Krzysztof Kozlowski
2025-11-24 15:38 ` Konstantin Ryabitsev
2025-11-24 15:58 ` ally heev
2025-11-24 16:28 ` Konstantin Ryabitsev
2025-11-25 7:20 ` ally heev
2025-11-25 13:54 ` Konstantin Ryabitsev
2025-11-25 16:00 ` ally heev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5419ba84c64e9146652864072b1941ef310de4f.camel@gmail.com \
--to=allyheev@gmail.com \
--cc=konstantin@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox