* [PATCH v1 1/1] util_macros.h: Make the header more resilient
@ 2025-04-28 7:27 Andy Shevchenko
2025-04-28 9:32 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2025-04-28 7:27 UTC (permalink / raw)
To: Andy Shevchenko, Alexandru Ardelean, linux-kernel; +Cc: Andrew Morton
Add missing header inclusions and protect against double inclusion.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/util_macros.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/util_macros.h b/include/linux/util_macros.h
index 7b64fb597f85..8239a7748f49 100644
--- a/include/linux/util_macros.h
+++ b/include/linux/util_macros.h
@@ -2,7 +2,10 @@
#ifndef _LINUX_HELPER_MACROS_H_
#define _LINUX_HELPER_MACROS_H_
+#include <linux/compiler_attributes.h>
#include <linux/math.h>
+#include <linux/typecheck.h>
+#include <linux/stddef.h>
/**
* for_each_if - helper for handling conditionals in various for_each macros
--
2.47.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] util_macros.h: Make the header more resilient
2025-04-28 7:27 [PATCH v1 1/1] util_macros.h: Make the header more resilient Andy Shevchenko
@ 2025-04-28 9:32 ` Andrew Morton
2025-04-28 10:06 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2025-04-28 9:32 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Alexandru Ardelean, linux-kernel
On Mon, 28 Apr 2025 10:27:54 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Add missing header inclusions and protect against double inclusion.
The patch doesn't "protect against double inclusion"?
> --- a/include/linux/util_macros.h
> +++ b/include/linux/util_macros.h
> @@ -2,7 +2,10 @@
> #ifndef _LINUX_HELPER_MACROS_H_
> #define _LINUX_HELPER_MACROS_H_
>
> +#include <linux/compiler_attributes.h>
> #include <linux/math.h>
> +#include <linux/typecheck.h>
> +#include <linux/stddef.h>
>
> /**
> * for_each_if - helper for handling conditionals in various for_each macros
> --
> 2.47.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] util_macros.h: Make the header more resilient
2025-04-28 9:32 ` Andrew Morton
@ 2025-04-28 10:06 ` Andy Shevchenko
2025-04-28 21:36 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2025-04-28 10:06 UTC (permalink / raw)
To: Andrew Morton; +Cc: Alexandru Ardelean, linux-kernel
On Mon, Apr 28, 2025 at 02:32:20AM -0700, Andrew Morton wrote:
> On Mon, 28 Apr 2025 10:27:54 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > Add missing header inclusions and protect against double inclusion.
> The patch doesn't "protect against double inclusion"?
Hmm... Not really. This is a copy'n'paste leftover. Can you remove that part
when applying or should I send a new version?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] util_macros.h: Make the header more resilient
2025-04-28 10:06 ` Andy Shevchenko
@ 2025-04-28 21:36 ` Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2025-04-28 21:36 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Alexandru Ardelean, linux-kernel
On Mon, 28 Apr 2025 13:06:06 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Mon, Apr 28, 2025 at 02:32:20AM -0700, Andrew Morton wrote:
> > On Mon, 28 Apr 2025 10:27:54 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >
> > > Add missing header inclusions and protect against double inclusion.
>
> > The patch doesn't "protect against double inclusion"?
>
> Hmm... Not really. This is a copy'n'paste leftover. Can you remove that part
> when applying or should I send a new version?
No probs, I altered the changelog.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-28 21:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-28 7:27 [PATCH v1 1/1] util_macros.h: Make the header more resilient Andy Shevchenko
2025-04-28 9:32 ` Andrew Morton
2025-04-28 10:06 ` Andy Shevchenko
2025-04-28 21:36 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox