[PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3 compatible override

[PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3 compatible override

[Abel Vesa]

It all started with the support for CRD back when we had different
compatibles for eDP and DP. Meanwhile, that has been sorted out and it
is now figured out at runtime while using only the DP compatible.

It's almost funny how this got copied over from CRD and spread to all
X Elite platforms.

TBH, the best reason to drop it ASAP is to make sure this doesn't spread
beyond X Elite to newer platforms.

Functionally nothing changes.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Abel Vesa (7):
      arm64: dts: qcom: x1e-crd: Drop useless DP3 compatible override
      arm64: dts: acom: x1e80100-qcp: Drop useless DP3 compatible override
      arm64: dts: qcom: x1e80100-t14s: Drop useless DP3 compatible override
      arm64: dts: qcom: x1e80100-s15: Drop useless DP3 compatible override
      arm64: dts: qcom: x1e80100-hp-x14: Drop useless DP3 compatible override
      arm64: dts: qcom: x1e80100: Drop useless DP3 compatible override
      arm64: dts: qcom: x1e80100-romulus: Drop useless DP3 compatible override

 arch/arm64/boot/dts/qcom/x1-crd.dtsi                        | 1 -
 arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 1 -
 arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts     | 1 -
 arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts       | 1 -
 arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts    | 1 -
 arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi    | 1 -
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts                   | 1 -
 7 files changed, 7 deletions(-)
---
base-commit: 7e69ad9a1f7ba8554c4d3d1ccbffcccafcd45c2e
change-id: 20250429-x1e80100-dts-drop-useless-dp-compatible-override-db8562c6b7cd

Best regards,
-- 
Abel Vesa <abel.vesa@linaro.org>

[PATCH 1/7] arm64: dts: qcom: x1e-crd: Drop useless DP3 compatible override

[Abel Vesa]

Back when display support was added initially to CRD, and we used to have
two separate compatibles for eDP and DP, it was supposed to override the
DP compatible with the eDP one in the board specific devicetree. Since
then, the DP driver has been reworked to figure out the eDP/DP at runtime
while only DP compatible remained in the end.

Even though the override does nothing basically, drop it to avoid
further confusion.

Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1-crd.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
index f73f053a46a08d875acdeeef9ac195a9b857ae3f..445127e8d07e34916695c7b79325370644b90341 100644
--- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
@@ -1148,7 +1148,6 @@ &mdss_dp2_out {
 };
 
 &mdss_dp3 {
-	compatible = "qcom,x1e80100-dp";
 	/delete-property/ #sound-dai-cells;
 
 	status = "okay";

-- 
2.34.1

[PATCH 2/7] arm64: dts: acom: x1e80100-qcp: Drop useless DP3 compatible override

[Abel Vesa]

Back when display support was added initially to CRD, and we used to have
two separate compatibles for eDP and DP, it was supposed to override the
DP compatible with the eDP one in the board specific devicetree. Since
then, the DP driver has been reworked to figure out the eDP/DP at runtime
while only DP compatible remained in the end.

This override was copied over from CRD which was the first X Elite
platform upstream to have display support.

Even though the override does nothing basically, drop it to avoid
further confusion.

Fixes: f9a9c11471da ("arm64: dts: qcom: x1e80100-qcp: Enable more support")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
index 470c4f826d49866a2af87f5e109672d51c9bc9cd..f5a911f23d8ce89b9c3a6470c14f6a68aebfcaa6 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
@@ -871,7 +871,6 @@ &mdss_dp2_out {
 };
 
 &mdss_dp3 {
-	compatible = "qcom,x1e80100-dp";
 	/delete-property/ #sound-dai-cells;
 
 	status = "okay";

-- 
2.34.1

[PATCH 3/7] arm64: dts: qcom: x1e80100-t14s: Drop useless DP3 compatible override

[Abel Vesa]

Back when display support was added initially to CRD, and we used to have
two separate compatibles for eDP and DP, it was supposed to override the
DP compatible with the eDP one in the board specific devicetree. Since
then, the DP driver has been reworked to figure out the eDP/DP at runtime
while only DP compatible remained in the end.

This override was copied over from CRD which was the first X Elite
platform upstream to have display support.

Even though the override does nothing basically, drop it to avoid
further confusion.

Fixes: 7d1cbe2f4985 ("arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
index 962fb050c55c4fd33f480a21a8c47a484d0c82b8..88cbf2a8186188acbc29baed13169fb940f83c73 100644
--- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
@@ -972,7 +972,6 @@ &mdss_dp1_out {
 };
 
 &mdss_dp3 {
-	compatible = "qcom,x1e80100-dp";
 	/delete-property/ #sound-dai-cells;
 
 	status = "okay";

-- 
2.34.1

[PATCH 4/7] arm64: dts: qcom: x1e80100-s15: Drop useless DP3 compatible override

[Abel Vesa]

Back when display support was added initially to CRD, and we used to have
two separate compatibles for eDP and DP, it was supposed to override the
DP compatible with the eDP one in the board specific devicetree. Since
then, the DP driver has been reworked to figure out the eDP/DP at runtime
while only DP compatible remained in the end.

This override was copied over from CRD which was the first X Elite
platform upstream to have display support.

Even though the override does nothing basically, drop it to avoid
further confusion.

Fixes: d0e2f8f62dff ("arm64: dts: qcom: Add device tree for ASUS Vivobook S 15")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
index fb9567817be6f887c9214cafbfbabda8b8cb8203..cf646a22366c63d1cc1659fab85dd424c55dca78 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
@@ -479,7 +479,6 @@ &mdss {
 };
 
 &mdss_dp3 {
-	compatible = "qcom,x1e80100-dp";
 	/delete-property/ #sound-dai-cells;
 
 	status = "okay";

-- 
2.34.1

[PATCH 5/7] arm64: dts: qcom: x1e80100-hp-x14: Drop useless DP3 compatible override

[Abel Vesa]

Back when display support was added initially to CRD, and we used to have
two separate compatibles for eDP and DP, it was supposed to override the
DP compatible with the eDP one in the board specific devicetree. Since
then, the DP driver has been reworked to figure out the eDP/DP at runtime
while only DP compatible remained in the end.

This override was copied over from CRD which was the first X Elite
platform upstream to have display support.

Even though the override does nothing basically, drop it to avoid
further confusion.

Fixes: 6f18b8d4142c ("arm64: dts: qcom: x1e80100-hp-x14: dt for HP Omnibook X Laptop 14")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
index 1a187dc3684a967b42817e44ff0df10202fe3362..f81e5a479f8d14e7b9c94ab08b5a4f0d9487bfca 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
@@ -1154,7 +1154,6 @@ &mdss_dp1_out {
 };
 
 &mdss_dp3 {
-	compatible = "qcom,x1e80100-dp";
 	/delete-property/ #sound-dai-cells;
 
 	status = "okay";

-- 
2.34.1

[PATCH 6/7] arm64: dts: qcom: x1e80100: Drop useless DP3 compatible override

[Abel Vesa]

Back when display support was added initially to CRD, and we used to have
two separate compatibles for eDP and DP, it was supposed to override the
DP compatible with the eDP one in the board specific devicetree. Since
then, the DP driver has been reworked to figure out the eDP/DP at runtime
while only DP compatible remained in the end.

This override was copied over from CRD which was the first X Elite
platform upstream to have display support.

Even though the override does nothing basically, drop it to avoid
further confusion.

Fixes: 45247fe17db2 ("arm64: dts: qcom: x1e80100: add Lenovo Thinkpad Yoga slim 7x devicetree")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
index 445d97d67d325853b7dcd2060523e7469ed4e6ea..e9eaf0d2b28bd4f83a8baa89197bc5b6b90d4ec9 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
@@ -615,7 +615,6 @@ &mdss {
 };
 
 &mdss_dp3 {
-	compatible = "qcom,x1e80100-dp";
 	/delete-property/ #sound-dai-cells;
 
 	status = "okay";

-- 
2.34.1

[PATCH 7/7] arm64: dts: qcom: x1e80100-romulus: Drop useless DP3 compatible override

[Abel Vesa]

Back when display support was added initially to CRD, and we used to have
two separate compatibles for eDP and DP, it was supposed to override the
DP compatible with the eDP one in the board specific devicetree. Since
then, the DP driver has been reworked to figure out the eDP/DP at runtime
while only DP compatible remained in the end.

This override was copied over from CRD which was the first X Elite
platform upstream to have display support.

Even though the override does nothing basically, drop it to avoid
further confusion.

Fixes: 09d77be56093 ("arm64: dts: qcom: Add support for X1-based Surface Laptop 7 devices")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
index da8cef62ae730266b8782ea0a7efedf51c9f547d..26ae19b34b37e0e3c67eb4543de898e94e62c678 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
@@ -945,7 +945,6 @@ &mdss {
 };
 
 &mdss_dp3 {
-	compatible = "qcom,x1e80100-dp";
 	/delete-property/ #sound-dai-cells;
 
 	status = "okay";

-- 
2.34.1

Re: [PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3 compatible override

[Johan Hovold]

On Tue, Apr 29, 2025 at 10:42:28AM +0300, Abel Vesa wrote:
> It all started with the support for CRD back when we had different
> compatibles for eDP and DP. Meanwhile, that has been sorted out and it
> is now figured out at runtime while using only the DP compatible.
> 
> It's almost funny how this got copied over from CRD and spread to all
> X Elite platforms.
> 
> TBH, the best reason to drop it ASAP is to make sure this doesn't spread
> beyond X Elite to newer platforms.
> 
> Functionally nothing changes.
> 
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> Abel Vesa (7):
>       arm64: dts: qcom: x1e-crd: Drop useless DP3 compatible override
>       arm64: dts: acom: x1e80100-qcp: Drop useless DP3 compatible override
>       arm64: dts: qcom: x1e80100-t14s: Drop useless DP3 compatible override
>       arm64: dts: qcom: x1e80100-s15: Drop useless DP3 compatible override
>       arm64: dts: qcom: x1e80100-hp-x14: Drop useless DP3 compatible override
>       arm64: dts: qcom: x1e80100: Drop useless DP3 compatible override
>       arm64: dts: qcom: x1e80100-romulus: Drop useless DP3 compatible override

Since this is essentially a clean up perhaps you should have squashed
these into one patch.

Either way:

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>

Re: [PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3 compatible override

[Abel Vesa]

On 25-04-29 10:57:44, Johan Hovold wrote:
> On Tue, Apr 29, 2025 at 10:42:28AM +0300, Abel Vesa wrote:
> > It all started with the support for CRD back when we had different
> > compatibles for eDP and DP. Meanwhile, that has been sorted out and it
> > is now figured out at runtime while using only the DP compatible.
> > 
> > It's almost funny how this got copied over from CRD and spread to all
> > X Elite platforms.
> > 
> > TBH, the best reason to drop it ASAP is to make sure this doesn't spread
> > beyond X Elite to newer platforms.
> > 
> > Functionally nothing changes.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> > Abel Vesa (7):
> >       arm64: dts: qcom: x1e-crd: Drop useless DP3 compatible override
> >       arm64: dts: acom: x1e80100-qcp: Drop useless DP3 compatible override
> >       arm64: dts: qcom: x1e80100-t14s: Drop useless DP3 compatible override
> >       arm64: dts: qcom: x1e80100-s15: Drop useless DP3 compatible override
> >       arm64: dts: qcom: x1e80100-hp-x14: Drop useless DP3 compatible override
> >       arm64: dts: qcom: x1e80100: Drop useless DP3 compatible override
> >       arm64: dts: qcom: x1e80100-romulus: Drop useless DP3 compatible override
> 
> Since this is essentially a clean up perhaps you should have squashed
> these into one patch.

I was actually thinking that before sending, but then I decided to add
the Fixes tag to each one. Since it's such a trivial worthless cleanup,
I wasn't sure if the Fixes tags were worth it either.

I can squash them if the consensus is that it's not backporting.

> 
> Either way:
> 
> Reviewed-by: Johan Hovold <johan+linaro@kernel.org>

Thanks!

Abel

Re: [PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3 compatible override

[Johan Hovold]

On Tue, Apr 29, 2025 at 12:05:58PM +0300, Abel Vesa wrote:
> On 25-04-29 10:57:44, Johan Hovold wrote:
> > On Tue, Apr 29, 2025 at 10:42:28AM +0300, Abel Vesa wrote:
> > > It all started with the support for CRD back when we had different
> > > compatibles for eDP and DP. Meanwhile, that has been sorted out and it
> > > is now figured out at runtime while using only the DP compatible.
> > > 
> > > It's almost funny how this got copied over from CRD and spread to all
> > > X Elite platforms.
> > > 
> > > TBH, the best reason to drop it ASAP is to make sure this doesn't spread
> > > beyond X Elite to newer platforms.
> > > 
> > > Functionally nothing changes.
> > > 
> > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > > ---
> > > Abel Vesa (7):
> > >       arm64: dts: qcom: x1e-crd: Drop useless DP3 compatible override
> > >       arm64: dts: acom: x1e80100-qcp: Drop useless DP3 compatible override
> > >       arm64: dts: qcom: x1e80100-t14s: Drop useless DP3 compatible override
> > >       arm64: dts: qcom: x1e80100-s15: Drop useless DP3 compatible override
> > >       arm64: dts: qcom: x1e80100-hp-x14: Drop useless DP3 compatible override
> > >       arm64: dts: qcom: x1e80100: Drop useless DP3 compatible override
> > >       arm64: dts: qcom: x1e80100-romulus: Drop useless DP3 compatible override
> > 
> > Since this is essentially a clean up perhaps you should have squashed
> > these into one patch.
> 
> I was actually thinking that before sending, but then I decided to add
> the Fixes tag to each one. Since it's such a trivial worthless cleanup,
> I wasn't sure if the Fixes tags were worth it either.

Right, since it's not a bug you should probably have skipped the Fixes
tags too.
 
> I can squash them if the consensus is that it's not backporting.

We should definitely not backport these as they are not fixing any bugs.

Johan

Re: [PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3 compatible override

[Abel Vesa]

On 25-04-29 11:13:04, Johan Hovold wrote:
> On Tue, Apr 29, 2025 at 12:05:58PM +0300, Abel Vesa wrote:
> > On 25-04-29 10:57:44, Johan Hovold wrote:
> > > On Tue, Apr 29, 2025 at 10:42:28AM +0300, Abel Vesa wrote:
> > > > It all started with the support for CRD back when we had different
> > > > compatibles for eDP and DP. Meanwhile, that has been sorted out and it
> > > > is now figured out at runtime while using only the DP compatible.
> > > > 
> > > > It's almost funny how this got copied over from CRD and spread to all
> > > > X Elite platforms.
> > > > 
> > > > TBH, the best reason to drop it ASAP is to make sure this doesn't spread
> > > > beyond X Elite to newer platforms.
> > > > 
> > > > Functionally nothing changes.
> > > > 
> > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > > > ---
> > > > Abel Vesa (7):
> > > >       arm64: dts: qcom: x1e-crd: Drop useless DP3 compatible override
> > > >       arm64: dts: acom: x1e80100-qcp: Drop useless DP3 compatible override
> > > >       arm64: dts: qcom: x1e80100-t14s: Drop useless DP3 compatible override
> > > >       arm64: dts: qcom: x1e80100-s15: Drop useless DP3 compatible override
> > > >       arm64: dts: qcom: x1e80100-hp-x14: Drop useless DP3 compatible override
> > > >       arm64: dts: qcom: x1e80100: Drop useless DP3 compatible override
> > > >       arm64: dts: qcom: x1e80100-romulus: Drop useless DP3 compatible override
> > > 
> > > Since this is essentially a clean up perhaps you should have squashed
> > > these into one patch.
> > 
> > I was actually thinking that before sending, but then I decided to add
> > the Fixes tag to each one. Since it's such a trivial worthless cleanup,
> > I wasn't sure if the Fixes tags were worth it either.
> 
> Right, since it's not a bug you should probably have skipped the Fixes
> tags too.
>  
> > I can squash them if the consensus is that it's not backporting.
> 
> We should definitely not backport these as they are not fixing any bugs.

Sure. Will drop Fixes tags and squash in the next version.

> 
> Johan

Abel

Re: [PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3 compatible override

[Dmitry Baryshkov]

On Tue, Apr 29, 2025 at 10:42:28AM +0300, Abel Vesa wrote:
> It all started with the support for CRD back when we had different
> compatibles for eDP and DP. Meanwhile, that has been sorted out and it
> is now figured out at runtime while using only the DP compatible.
> 
> It's almost funny how this got copied over from CRD and spread to all
> X Elite platforms.
> 
> TBH, the best reason to drop it ASAP is to make sure this doesn't spread
> beyond X Elite to newer platforms.
> 
> Functionally nothing changes.
> 
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> Abel Vesa (7):
>       arm64: dts: qcom: x1e-crd: Drop useless DP3 compatible override
>       arm64: dts: acom: x1e80100-qcp: Drop useless DP3 compatible override
>       arm64: dts: qcom: x1e80100-t14s: Drop useless DP3 compatible override
>       arm64: dts: qcom: x1e80100-s15: Drop useless DP3 compatible override
>       arm64: dts: qcom: x1e80100-hp-x14: Drop useless DP3 compatible override
>       arm64: dts: qcom: x1e80100: Drop useless DP3 compatible override
>       arm64: dts: qcom: x1e80100-romulus: Drop useless DP3 compatible override

For the series:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


> 
>  arch/arm64/boot/dts/qcom/x1-crd.dtsi                        | 1 -
>  arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 1 -
>  arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts     | 1 -
>  arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts       | 1 -
>  arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts    | 1 -
>  arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi    | 1 -
>  arch/arm64/boot/dts/qcom/x1e80100-qcp.dts                   | 1 -
>  7 files changed, 7 deletions(-)
> ---
> base-commit: 7e69ad9a1f7ba8554c4d3d1ccbffcccafcd45c2e
> change-id: 20250429-x1e80100-dts-drop-useless-dp-compatible-override-db8562c6b7cd
> 
> Best regards,
> -- 
> Abel Vesa <abel.vesa@linaro.org>
> 

-- 
With best wishes
Dmitry

Re: [PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3 compatible override

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

Hi,

On Tue, Apr 29, 2025 at 10:42:28AM +0300, Abel Vesa wrote:
> It all started with the support for CRD back when we had different
> compatibles for eDP and DP. Meanwhile, that has been sorted out and it
> is now figured out at runtime while using only the DP compatible.
> 
> It's almost funny how this got copied over from CRD and spread to all
> X Elite platforms.
> 
> TBH, the best reason to drop it ASAP is to make sure this doesn't spread
> beyond X Elite to newer platforms.
> 
> Functionally nothing changes.

Looking at the diff I wonder if this part should also be simplified:

/delete-property/ #sound-dai-cells;

This is done by all upstream X1E boards, so maybe just drop the
#sound-dai-cells directly in x1e80100.dtsi?

Greetings,

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3 compatible override

[Jens Glathe]

On 4/30/25 01:26, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Apr 29, 2025 at 10:42:28AM +0300, Abel Vesa wrote:
>> ...
> Looking at the diff I wonder if this part should also be simplified:
>
> /delete-property/ #sound-dai-cells;
>
> This is done by all upstream X1E boards, so maybe just drop the
> #sound-dai-cells directly in x1e80100.dtsi?
>
This is for phy configurations where a display panel is connected that 
has no sound channels. Not guaranteed that it's always on mdss_dp3.

with best regards

Jens Gathe

Re: [PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3 compatible override

[Abel Vesa]

On 25-04-30 01:26:13, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, Apr 29, 2025 at 10:42:28AM +0300, Abel Vesa wrote:
> > It all started with the support for CRD back when we had different
> > compatibles for eDP and DP. Meanwhile, that has been sorted out and it
> > is now figured out at runtime while using only the DP compatible.
> > 
> > It's almost funny how this got copied over from CRD and spread to all
> > X Elite platforms.
> > 
> > TBH, the best reason to drop it ASAP is to make sure this doesn't spread
> > beyond X Elite to newer platforms.
> > 
> > Functionally nothing changes.
> 
> Looking at the diff I wonder if this part should also be simplified:
> 
> /delete-property/ #sound-dai-cells;
> 
> This is done by all upstream X1E boards, so maybe just drop the
> #sound-dai-cells directly in x1e80100.dtsi?

Yeah, I'm not sure about that.

Though the DP3 PHY is currently used as eDP, I think it could be used
as DP. So I think it makes more sense to keep the DP3 controller as is
in the SoC dtsi and delete the #sound-dai-cells property in each board
specific dts. Don't know if it will ever be the case with this SoC, but
maybe someone will use DP3 with the PHY configured as DP rather than
eDP.

Not sure if I'm 100% right about this though.

Dmitry, Bjorn, do you think that is accurate enough?

> 
> Greetings,
> 
> -- Sebastian

Re: [PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3 compatible override

[Konrad Dybcio]

On 4/30/25 11:39 AM, Abel Vesa wrote:
> On 25-04-30 01:26:13, Sebastian Reichel wrote:
>> Hi,
>>
>> On Tue, Apr 29, 2025 at 10:42:28AM +0300, Abel Vesa wrote:
>>> It all started with the support for CRD back when we had different
>>> compatibles for eDP and DP. Meanwhile, that has been sorted out and it
>>> is now figured out at runtime while using only the DP compatible.
>>>
>>> It's almost funny how this got copied over from CRD and spread to all
>>> X Elite platforms.
>>>
>>> TBH, the best reason to drop it ASAP is to make sure this doesn't spread
>>> beyond X Elite to newer platforms.
>>>
>>> Functionally nothing changes.
>>
>> Looking at the diff I wonder if this part should also be simplified:
>>
>> /delete-property/ #sound-dai-cells;
>>
>> This is done by all upstream X1E boards, so maybe just drop the
>> #sound-dai-cells directly in x1e80100.dtsi?
> 
> Yeah, I'm not sure about that.
> 
> Though the DP3 PHY is currently used as eDP, I think it could be used
> as DP. So I think it makes more sense to keep the DP3 controller as is
> in the SoC dtsi and delete the #sound-dai-cells property in each board
> specific dts. Don't know if it will ever be the case with this SoC, but
> maybe someone will use DP3 with the PHY configured as DP rather than
> eDP.
> 
> Not sure if I'm 100% right about this though.
> 
> Dmitry, Bjorn, do you think that is accurate enough?

I'd say just keep it everywhere, the physical capability of the
controller to send audio streams is there, but is left unused by
the specific eDP usecase (which is determined dynamically)

Konrad

Re: [PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3 compatible override

[Dmitry Baryshkov]

On Wed, Apr 30, 2025 at 12:39:13PM +0300, Abel Vesa wrote:
> On 25-04-30 01:26:13, Sebastian Reichel wrote:
> > Hi,
> > 
> > On Tue, Apr 29, 2025 at 10:42:28AM +0300, Abel Vesa wrote:
> > > It all started with the support for CRD back when we had different
> > > compatibles for eDP and DP. Meanwhile, that has been sorted out and it
> > > is now figured out at runtime while using only the DP compatible.
> > > 
> > > It's almost funny how this got copied over from CRD and spread to all
> > > X Elite platforms.
> > > 
> > > TBH, the best reason to drop it ASAP is to make sure this doesn't spread
> > > beyond X Elite to newer platforms.
> > > 
> > > Functionally nothing changes.
> > 
> > Looking at the diff I wonder if this part should also be simplified:
> > 
> > /delete-property/ #sound-dai-cells;
> > 
> > This is done by all upstream X1E boards, so maybe just drop the
> > #sound-dai-cells directly in x1e80100.dtsi?
> 
> Yeah, I'm not sure about that.
> 
> Though the DP3 PHY is currently used as eDP, I think it could be used
> as DP. So I think it makes more sense to keep the DP3 controller as is
> in the SoC dtsi and delete the #sound-dai-cells property in each board
> specific dts. Don't know if it will ever be the case with this SoC, but
> maybe someone will use DP3 with the PHY configured as DP rather than
> eDP.
> 
> Not sure if I'm 100% right about this though.
> 
> Dmitry, Bjorn, do you think that is accurate enough?

Yes, this sounds logical. DP3 is repurposed for eDP on a board level, so
the SoC configuration should not contain any specific config for that
port.

> 
> > 
> > Greetings,
> > 
> > -- Sebastian
> 
> 

-- 
With best wishes
Dmitry