Re: [PATCH v2 3/5] iio: adc: ad7606: add offset and phase calibration support

[Andy Shevchenko <andy@kernel.org>]

On Tue, May 06, 2025 at 02:59:50PM +0200, Angelo Dureghello wrote:
> On 02.05.2025 16:39, Andy Shevchenko wrote:
> > On Fri, May 02, 2025 at 03:27:00PM +0200, Angelo Dureghello wrote:

...

> > > +static int ad7606_get_calib_offset(struct ad7606_state *st, int ch, int *val)
> > > +{
> > > +	int ret;
> > > +
> > > +	ret = st->bops->reg_read(st, AD7606_CALIB_OFFSET(ch));
> > > +	if (ret < 0)
> > > +		return ret;
> > > +
> > > +	*val = st->chip_info->calib_offset_avail[0] +
> > > +		ret * st->chip_info->calib_offset_avail[1];
> > 
> > Something wrong with the indentation.
> > 
> > > +	return 0;
> > > +}

...

> > > +static int ad7606_set_calib_phase(struct ad7606_state *st, int ch, int val,
> > > +				  int val2)
> > > +{
> > > +	int wreg, start_ns, step_ns, stop_ns;
> > 
> > > +	if (val != 0)
> > > +		return -EINVAL;
> > > +
> > > +	start_ns = st->chip_info->calib_phase_avail[0][1];
> > > +	step_ns = st->chip_info->calib_phase_avail[1][1];
> > > +	stop_ns = st->chip_info->calib_phase_avail[2][1];
> > > +
> > > +	/*
> > > +	 * ad7606b: phase dielay from 0 to 318.75 μs in steps of 1.25 μs.
> > > +	 * ad7606c-16/18: phase delay from 0 µs to 255 µs in steps of 1 µs.
> > > +	 */
> > > +	if (val2 < start_ns || val2 > stop_ns)
> > > +			return -EINVAL;
> > 
> > Wrong indentation. Please fix in all places where it happens.
> 
> as already said, my code is correct,

Evidently no.

> 1 tab after the if, anywone knows why git formats the patch this way ?  

It's you, who should answer this and fix it.

> > > +	wreg = val2 / step_ns;
> > > +
> > > +	return st->bops->reg_write(st, AD7606_CALIB_PHASE(ch), wreg);
> > > +}

-- 
With Best Regards,
Andy Shevchenko