From: Andy Shevchenko <andy@kernel.org>
To: Angelo Dureghello <adureghello@baylibre.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/5] iio: adc: ad7606: add offset and phase calibration support
Date: Wed, 7 May 2025 17:46:28 +0300 [thread overview]
Message-ID: <aBtyRHFW-OhhwXsE@smile.fi.intel.com> (raw)
In-Reply-To: <wvflf3rmqaonm6gt45gqtxndprkqbhgvce5z7c4z7c7jgdg4tm@kofkvcbvnaav>
On Tue, May 06, 2025 at 04:46:35PM +0200, Angelo Dureghello wrote:
> On 02.05.2025 16:39, Andy Shevchenko wrote:
> > On Fri, May 02, 2025 at 03:27:00PM +0200, Angelo Dureghello wrote:
...
> > > + *val = st->chip_info->calib_offset_avail[0] +
> > > + ret * st->chip_info->calib_offset_avail[1];
> >
> > Something wrong with the indentation.
>
> Can eventually adjust to:
>
> *val = st->chip_info->calib_offset_avail[0] + ret *
> st->chip_info->calib_offset_avail[1];
>
> this is genrelly ok.
This will be illogical split. The idea is to replace second TAB with 7 spaces
(instead of 8).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-05-07 14:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 13:26 [PATCH v2 0/5] iio: adc: add ad7606 calibration support Angelo Dureghello
2025-05-02 13:26 ` [PATCH v2 1/5] Documentation: ABI: IIO: add calibconv_delay documentation Angelo Dureghello
2025-05-04 15:16 ` Jonathan Cameron
2025-05-04 19:48 ` David Lechner
2025-05-05 13:28 ` Jonathan Cameron
2025-05-02 13:26 ` [PATCH v2 2/5] iio: core: add ADC delay calibration definition Angelo Dureghello
2025-05-02 13:27 ` [PATCH v2 3/5] iio: adc: ad7606: add offset and phase calibration support Angelo Dureghello
2025-05-02 13:39 ` Andy Shevchenko
2025-05-06 12:59 ` Angelo Dureghello
2025-05-07 14:45 ` Andy Shevchenko
2025-05-06 14:46 ` Angelo Dureghello
2025-05-07 14:46 ` Andy Shevchenko [this message]
2025-05-02 19:04 ` David Lechner
2025-05-04 8:30 ` Nuno Sá
2025-05-04 8:34 ` Nuno Sá
2025-05-04 15:21 ` Jonathan Cameron
2025-05-02 13:27 ` [PATCH v2 4/5] dt-bindings: iio: adc: adi,ad7606: add gain " Angelo Dureghello
2025-05-02 16:30 ` Conor Dooley
2025-05-02 18:54 ` David Lechner
2025-05-02 13:27 ` [PATCH v2 5/5] iio: adc: ad7606: " Angelo Dureghello
2025-05-02 13:36 ` Andy Shevchenko
2025-05-02 19:04 ` David Lechner
2025-05-04 8:35 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBtyRHFW-OhhwXsE@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=adureghello@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox