* [PATCH] pinctrl: tigerlake: Document supported platforms in Kconfig help
@ 2025-04-30 15:32 Ariel Simulevski
2025-04-30 18:14 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Ariel Simulevski @ 2025-04-30 15:32 UTC (permalink / raw)
To: andy; +Cc: linux-gpio, linux-kernel, Ariel Simulevski, Guido Trentalancia
The Tiger Lake pinctrl driver is also used by some Alder Lake platforms
that reuse the same GPIO IP blocks.
Update the Kconfig help texts for both drivers to document supported
platforms and clarify when CONFIG_PINCTRL_TIGERLAKE may be required.
Supported platforms:
- Tiger Lake (all variants)
- Alder Lake-P
Reported-by: Guido Trentalancia <guido2022@trentalancia.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=220056
Signed-off-by: Ariel Simulevski <ariel@simulevski.at>
---
drivers/pinctrl/intel/Kconfig | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/pinctrl/intel/Kconfig b/drivers/pinctrl/intel/Kconfig
index 248c2e558ff3..f1114828457d 100644
--- a/drivers/pinctrl/intel/Kconfig
+++ b/drivers/pinctrl/intel/Kconfig
@@ -54,6 +54,9 @@ config PINCTRL_ALDERLAKE
This pinctrl driver provides an interface that allows configuring
of Intel Alder Lake PCH pins and using them as GPIOs.
+ Some platforms may reuse GPIO IP blocks from earlier generations
+ and require CONFIG_PINCTRL_TIGERLAKE instead.
+
config PINCTRL_BROXTON
tristate "Intel Broxton pinctrl and GPIO driver"
select PINCTRL_INTEL
@@ -161,5 +164,11 @@ config PINCTRL_TIGERLAKE
This pinctrl driver provides an interface that allows configuring
of Intel Tiger Lake PCH pins and using them as GPIOs.
+ Also used on some Alder Lake platforms that share compatible GPIO IP.
+
+ Supported platforms:
+ - Tiger Lake (all variants)
+ - Alder Lake-P
+
source "drivers/pinctrl/intel/Kconfig.tng"
endmenu
--
2.49.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: tigerlake: Document supported platforms in Kconfig help
2025-04-30 15:32 Ariel Simulevski
@ 2025-04-30 18:14 ` Andy Shevchenko
2025-04-30 18:16 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2025-04-30 18:14 UTC (permalink / raw)
To: Ariel Simulevski; +Cc: andy, linux-gpio, linux-kernel, Guido Trentalancia
On Wed, Apr 30, 2025 at 6:32 PM Ariel Simulevski <ariel@simulevski.at> wrote:
Technically this is a v2 of the previous patch, but it has been
changed a lot, so for _this_ time it's okay to have it still v1. Also
note when v2 or any new version of patch is required the changelog
must be provided (after the cutter '---' line below).
> The Tiger Lake pinctrl driver is also used by some Alder Lake platforms
> that reuse the same GPIO IP blocks.
>
> Update the Kconfig help texts for both drivers to document supported
> platforms
> and clarify when CONFIG_PINCTRL_TIGERLAKE may be required.
This should be done in the same way....
> Supported platforms:
> - Tiger Lake (all variants)
Have you checked this (that's all versions of Tiger Lake are in this driver)?
> - Alder Lake-P
> + Some platforms may reuse GPIO IP blocks from earlier generations
> + and require CONFIG_PINCTRL_TIGERLAKE instead.
Just list the supported platforms:
- Alder Lake-N
- Alder Lake-S
And I believe some of Raptor Lake:s are also require this driver.
> + Also used on some Alder Lake platforms that share compatible GPIO IP.
No need to have this text, it's obvious from the below list.
> + Supported platforms:
> + - Tiger Lake (all variants)
> + - Alder Lake-P
...
With that, waiting for v2.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: tigerlake: Document supported platforms in Kconfig help
2025-04-30 18:14 ` Andy Shevchenko
@ 2025-04-30 18:16 ` Andy Shevchenko
[not found] ` <CAMz-Jg-nNqUyzWpayBhPqhsGWOAKJPEa7uRWpOX0HWJDzqiQsg@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2025-04-30 18:16 UTC (permalink / raw)
To: Ariel Simulevski; +Cc: andy, linux-gpio, linux-kernel, Guido Trentalancia
On Wed, Apr 30, 2025 at 9:14 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Apr 30, 2025 at 6:32 PM Ariel Simulevski <ariel@simulevski.at> wrote:
>
> Technically this is a v2 of the previous patch, but it has been
> changed a lot, so for _this_ time it's okay to have it still v1. Also
> note when v2 or any new version of patch is required the changelog
> must be provided (after the cutter '---' line below).
On top of that, you forgot to include (all) maintainers of the
respective code. I recommend using my "smart" script [1] for sending
patches to the Linux kernel subsystems.
...
> With that, waiting for v2.
[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: tigerlake: Document supported platforms in Kconfig help
@ 2025-05-05 18:07 Ariel Simulevski
2025-05-07 16:05 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Ariel Simulevski @ 2025-05-05 18:07 UTC (permalink / raw)
To: Andy Shevchenko
Cc: andy, Ariel Simulevski, Guido Trentalancia, linux-gpio,
linux-kernel
Hi Andy,
Thanks for the feedback.
Just to confirm: for the Kconfig help text, would you prefer keeping
it strictly to a plain list of supported platforms (e.g. "Supported
platforms: Tiger Lake, Alder Lake-N, Alder Lake-S") with no additional
explanation or context? And only PINCTRL_TIGERLAKE because I think
that the note on PINCTRL_ALDERLAKE is actually quite helpful.
I want to make sure the v2 follows your expectations exactly.
Best,
Ariel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: tigerlake: Document supported platforms in Kconfig help
[not found] ` <CAMz-Jg-nNqUyzWpayBhPqhsGWOAKJPEa7uRWpOX0HWJDzqiQsg@mail.gmail.com>
@ 2025-05-05 18:10 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2025-05-05 18:10 UTC (permalink / raw)
To: Ariel Simulevski; +Cc: mika.westerberg, linux-gpio, linux-kernel, linus.walleij
First of all, please do not top-post! In the (Linux kernel related)
mailing lists we do answer after the respective context.
On Mon, May 5, 2025 at 9:02 PM Ariel Simulevski <ariel@simulevski.at> wrote:
> Thanks for the feedback.
>
> Just to confirm: for the Kconfig help text, would you prefer keeping it strictly to a plain list of supported platforms (e.g. "Supported platforms: Tiger Lake, Alder Lake-N, Alder Lake-S") with no additional explanation or context?
Yes.
> And only PINCTRL_TIGERLAKE because I think that the note on PINCTRL_ALDERLAKE is actually quite helpful.
The similar List should be added to all of them, but after good
research done. The note about the certain touchpad or any consumer is
not okay. This driver is not about a particular platform or
configuration. That note gives actually an opposite, i.e. confusion.
> I want to make sure the v2 follows your expectations exactly.
Sure!
> On Wed, Apr 30, 2025 at 8:17 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>>
>> On Wed, Apr 30, 2025 at 9:14 PM Andy Shevchenko
>> <andy.shevchenko@gmail.com> wrote:
>> > On Wed, Apr 30, 2025 at 6:32 PM Ariel Simulevski <ariel@simulevski.at> wrote:
>> >
>> > Technically this is a v2 of the previous patch, but it has been
>> > changed a lot, so for _this_ time it's okay to have it still v1. Also
>> > note when v2 or any new version of patch is required the changelog
>> > must be provided (after the cutter '---' line below).
>>
>> On top of that, you forgot to include (all) maintainers of the
>> respective code. I recommend using my "smart" script [1] for sending
>> patches to the Linux kernel subsystems.
...
>> > With that, waiting for v2.
>>
>> [1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: tigerlake: Document supported platforms in Kconfig help
2025-05-05 18:07 [PATCH] pinctrl: tigerlake: Document supported platforms in Kconfig help Ariel Simulevski
@ 2025-05-07 16:05 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2025-05-07 16:05 UTC (permalink / raw)
To: Ariel Simulevski; +Cc: Guido Trentalancia, linux-gpio, linux-kernel
On Mon, May 05, 2025 at 08:07:23PM +0200, Ariel Simulevski wrote:
> Hi Andy,
>
> Thanks for the feedback.
>
> Just to confirm: for the Kconfig help text, would you prefer keeping
> it strictly to a plain list of supported platforms (e.g. "Supported
> platforms: Tiger Lake, Alder Lake-N, Alder Lake-S") with no additional
> explanation or context?
Yes.
> And only PINCTRL_TIGERLAKE because I think
> that the note on PINCTRL_ALDERLAKE is actually quite helpful.
That note, about particular touchpad or touchscreen is confusing as
it is small part of the users that be hinted by it. The rest won't
understand why it is there. The driver runs on tons of different
platforms and configurations, so such a niche notices are not
applicable here.
> I want to make sure the v2 follows your expectations exactly.
Sure.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-05-07 16:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-05 18:07 [PATCH] pinctrl: tigerlake: Document supported platforms in Kconfig help Ariel Simulevski
2025-05-07 16:05 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2025-04-30 15:32 Ariel Simulevski
2025-04-30 18:14 ` Andy Shevchenko
2025-04-30 18:16 ` Andy Shevchenko
[not found] ` <CAMz-Jg-nNqUyzWpayBhPqhsGWOAKJPEa7uRWpOX0HWJDzqiQsg@mail.gmail.com>
2025-05-05 18:10 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox