* [PATCH v2 2/2] f2fs: add f2fs_bug_on() in f2fs_quota_read()
@ 2025-05-13 3:19 Chao Yu
2025-05-13 17:33 ` Jaegeuk Kim
0 siblings, 1 reply; 2+ messages in thread
From: Chao Yu @ 2025-05-13 3:19 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, Chao Yu
mapping_read_folio_gfp() will return a folio, it should always be
uptodate, let's check folio uptodate status to detect any potenial
bug.
Signed-off-by: Chao Yu <chao@kernel.org>
---
v2:
- just add f2fs_bug_on(), get rid of error handling.
fs/f2fs/super.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 0ee783224953..8c77a625427c 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2973,6 +2973,12 @@ static ssize_t f2fs_quota_read(struct super_block *sb, int type, char *data,
goto repeat;
}
+ /*
+ * should never happen, just leave f2fs_bug_on() here to catch
+ * any potential bug.
+ */
+ f2fs_bug_on(sbi, !folio_test_uptodate(folio));
+
memcpy_from_folio(data, folio, offset, tocopy);
f2fs_folio_put(folio, true);
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 2/2] f2fs: add f2fs_bug_on() in f2fs_quota_read()
2025-05-13 3:19 [PATCH v2 2/2] f2fs: add f2fs_bug_on() in f2fs_quota_read() Chao Yu
@ 2025-05-13 17:33 ` Jaegeuk Kim
0 siblings, 0 replies; 2+ messages in thread
From: Jaegeuk Kim @ 2025-05-13 17:33 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-f2fs-devel, linux-kernel
On 05/13, Chao Yu wrote:
> mapping_read_folio_gfp() will return a folio, it should always be
> uptodate, let's check folio uptodate status to detect any potenial
> bug.
>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> v2:
> - just add f2fs_bug_on(), get rid of error handling.
> fs/f2fs/super.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 0ee783224953..8c77a625427c 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -2973,6 +2973,12 @@ static ssize_t f2fs_quota_read(struct super_block *sb, int type, char *data,
> goto repeat;
> }
>
> + /*
> + * should never happen, just leave f2fs_bug_on() here to catch
> + * any potential bug.
> + */
> + f2fs_bug_on(sbi, !folio_test_uptodate(folio));
Applied with F2FS_SB(sb)
> +
> memcpy_from_folio(data, folio, offset, tocopy);
> f2fs_folio_put(folio, true);
>
> --
> 2.49.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-13 17:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-13 3:19 [PATCH v2 2/2] f2fs: add f2fs_bug_on() in f2fs_quota_read() Chao Yu
2025-05-13 17:33 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox